Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix data race of DeltaIndexManager. #4459

Merged
merged 3 commits into from
Mar 28, 2022
Merged

Fix data race of DeltaIndexManager. #4459

merged 3 commits into from
Mar 28, 2022

Conversation

JinheLin
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #4405

Problem Summary: current_size may be read and written concurrently.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 28, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SchrodingerZhu
  • lidezhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 28, 2022
lidezhu
lidezhu approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@lidezhu lidezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 28, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 28, 2022
@SchrodingerZhu
Copy link
Contributor

/run-sanitizer-test tsan

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 needs-cherry-pick-release-5.1 PR which needs to be cherry-picked to release-5.1 needs-cherry-pick-release-5.2 PR which needs to be cherry-picked to release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 Type: Need cherry pick to release-6.0 and removed do-not-merge/needs-triage-completed labels Mar 28, 2022
@JinheLin
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@JinheLin: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e4b8a98

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 28, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 28, 2022

Coverage for changed files

Filename                                                                                                          Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Storages/DeltaMerge/DeltaIndexManager.cpp          54                 8    85.19%           4                 0   100.00%          83                 8    90.36%          32                13    59.38%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                                  54                 8    85.19%           4                 0   100.00%          83                 8    90.36%          32                13    59.38%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17049      9575             43.84%    191778  97012        49.41%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit e5a78d3 into pingcap:master Mar 28, 2022
This was referenced Mar 28, 2022
Closed
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4469.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4470.

This was referenced Mar 28, 2022
Closed
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4471.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 28, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4472.

@JaySon-Huang JaySon-Huang deleted the fix_data_race branch March 28, 2022 07:23
ti-chi-bot added a commit that referenced this pull request Mar 28, 2022
@ti-chi-bot
Fix data race of DeltaIndexManager. (#4459) (#4472)
066f1b7 
close #4405
@JinheLin
Copy link
Contributor Author

/run-cherry-pick release-5.2

@JinheLin
Copy link
Contributor Author

/run-cherry-pick

@JinheLin JinheLin mentioned this pull request Apr 15, 2022
Merged
12 tasks
@JaySon-Huang
Copy link
Contributor

/cherry-pick release-5.4

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 27, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

@JaySon-Huang: new pull request created: #4772.

In response to this:

/cherry-pick release-5.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@JaySon-Huang
Copy link
Contributor

/cherry-pick release-5.0

@JaySon-Huang
Copy link
Contributor

/cherry-pick release-5.1

@JaySon-Huang
Copy link
Contributor

/cherry-pick release-5.3

@ti-chi-bot
Copy link
Member

@JaySon-Huang: new pull request created: #4773.

In response to this:

/cherry-pick release-5.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

This was referenced Apr 27, 2022
Merged
Merged
@ti-chi-bot
Copy link
Member

@JaySon-Huang: new pull request created: #4774.

In response to this:

/cherry-pick release-5.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 27, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

@JaySon-Huang: new pull request created: #4775.

In response to this:

/cherry-pick release-5.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot added a commit that referenced this pull request Apr 27, 2022
@ti-chi-bot
Fix data race of DeltaIndexManager. (#4459) (#4772)
395a177 
close #4405
ti-chi-bot added a commit that referenced this pull request Jun 15, 2022
@ti-chi-bot
Fix data race of DeltaIndexManager. (#4459) (#4775)
12fb435 
close #4405
ti-chi-bot added a commit that referenced this pull request Jun 15, 2022
@ti-chi-bot
Fix data race of DeltaIndexManager. (#4459) (#4774)
d274700 
close #4405
ti-chi-bot added a commit that referenced this pull request Jun 16, 2022
@ti-chi-bot
Fix data race of DeltaIndexManager. (#4459) (#4773)
a4b37d1 
close #4405
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidezhu lidezhu lidezhu approved these changes

@SchrodingerZhu SchrodingerZhu SchrodingerZhu approved these changes

@flowbehappy flowbehappy Awaiting requested review from flowbehappy

@JaySon-Huang JaySon-Huang Awaiting requested review from JaySon-Huang

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 needs-cherry-pick-release-5.1 PR which needs to be cherry-picked to release-5.1 needs-cherry-pick-release-5.2 PR which needs to be cherry-picked to release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 Type: Need cherry pick to release-6.0 release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ThreadSanitizer reports data race in DeltaIndexManager::refreshRef.
6 participants
@JinheLin @ti-chi-bot @SchrodingerZhu @sre-bot @JaySon-Huang @lidezhu