Remove invalid blob file after BlobStore restored. #4475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
do-not-merge/needs-linked-issue
release-note-none
|
I think this PR is waiting for #3938 to be merged first? |
yes. |
ti-chi-bot
added
the
needs-rebase
Signed-off-by: jiaqizho <zhoujiaqi@pingcap.com>
ti-chi-bot
added
size/M
Comment on lines
843
to
855
| const auto & blob_id = std::stoull(ss[1]); | ||
| bool found = false; | ||
| for (const auto & stat : stats) | ||
| { | ||
| if (stat->id == blob_id) | ||
| { | ||
| found = true; | ||
| break; | ||
| } | ||
| } | ||
|
|
||
| if (!found) | ||
| { |
There was a problem hiding this comment.
What about saving a std::set<BlobFileID> in L804~L808 to replace this O(n) searching?
There was a problem hiding this comment.
In this case, every blob_id in the current path(in disk) will compare with the stats which also belong to the current path.
But if we used std::set<BlobFileID> in L804~L808, Then every blob_id in the current path(in disk) will compare with all of the stats.
There was a problem hiding this comment.
No, L804~L808 is inside the loop of current path, so you only compare the id with stats under this path.
There was a problem hiding this comment.
changed to set_difference
Co-authored-by: JaySon <tshent@qq.com>
Co-authored-by: JaySon <tshent@qq.com>
ti-chi-bot
added
size/XL
JaySon-Huang
approved these changes
Mar 31, 2022
ti-chi-bot
added
status/LGT2
|
|
|
|
|
/merge |
|
@jiaqizho: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 298264b
|
ti-chi-bot
added
the
status/can-merge
|
/hold @jiaqizho PTAL |
ti-chi-bot
added
the
do-not-merge/hold
Waiting for |
ti-chi-bot
added
needs-rebase
ti-chi-bot
removed
the
needs-rebase
|
/run-all-tests |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
|
/merge |
|
@jiaqizho: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 338da4b
|
ti-chi-bot
added
the
status/can-merge
|
/unhold |
ti-chi-bot
removed
the
do-not-merge/hold
|
@jiaqizho: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #3594
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note