*: Fix saving reference to temporary object

[JaySon-Huang]

What problem does this PR solve?

Issue Number: close #4476, close #4478

Problem Summary: as the issue described.

When we run into these lines, we create two temporary empty vectors for sender_target_task_ids and receiver_source_task_ids_map as they are not important.

However, we save them as reference in MPPInfo, which introduce stack use-after-scope error.

tiflash/dbms/src/Debug/dbgFuncCoprocessor.cpp

Lines 2176 to 2180 in e5a78d3

	else
	{
	MPPInfo mpp_info(properties.start_ts, -1, -1, {}, {});
	ret.push_back(toQueryTask(properties, mpp_info, context));
	}

---

data race for static var num_call in PageStorage V2, only happens under debug mode

tiflash/dbms/src/Storages/Page/V2/PageStorage.cpp

Lines 502 to 521 in 0a484f7

	try
	{
	wb.setSequence(++write_batch_seq); // Set sequence number to keep ordering between writers.
	#ifdef FIU_ENABLE
	static int num_call = 0;
	num_call++;
	#endif
	fiu_do_on(FailPoints::random_slow_page_storage_write, {
	if (num_call % 10 == 7)
	{
	pcg64 rng(randomSeed());
	std::chrono::milliseconds ms{std::uniform_int_distribution(0, 900)(rng)}; // 0~900 milliseconds
	LOG_FMT_WARNING(
	log,
	"Failpoint random_slow_page_storage_write sleep for {}ms, WriteBatch with sequence={}",
	ms.count(),
	wb.getSequence());
	std::this_thread::sleep_for(ms);
	}
	});

What is changed and how it works?

Save a copy instead of an reference

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• fuzhe1989
• windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[JaySon-Huang]

/run-sanitizer-test asan tsan

[JaySon-Huang]

/run-sanitizer-test asan tsan

[JaySon-Huang]

/run-sanitizer-test asan tsan

[windtalker]

LGTM

[JaySon-Huang]

/run-sanitizer-test asan tsan

[JaySon-Huang]

/merge

[ti-chi-bot]

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 8b1e6e8

[sre-bot]

Coverage for changed files

Filename                             Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Debug/dbgFuncCoprocessor.cpp             933               639    31.51%          97                56    42.27%        2182              1492    31.62%         798               552    30.83%
Storages/Page/V2/PageStorage.cpp         518               146    71.81%          36                 3    91.67%         882               163    81.52%         350               144    58.86%
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                   1451               785    45.90%         133                59    55.64%        3064              1655    45.99%        1148               696    39.37%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17049      9575             43.84%    191778  97007        49.42%

full coverage report (for internal network access only)