Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a log prefix into BlobStore and WALStore #4492

Merged
merged 4 commits into from
Mar 31, 2022
Merged

Add a log prefix into BlobStore and WALStore #4492

merged 4 commits into from
Mar 31, 2022

Conversation

jiaqizho
Copy link
Contributor

@jiaqizho jiaqizho commented Mar 30, 2022 •
edited
Loading

Signed-off-by: jiaqizho zhoujiaqi@pingcap.com

What problem does this PR solve?

Issue Number: ref #3594

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@jiaqizho
Add log prefix into blobstore and walstore
f36227b 
Signed-off-by: jiaqizho <zhoujiaqi@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 30, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CalvinNeo
  • JaySon-Huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Mar 30, 2022
@jiaqizho
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 30, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 30, 2022

Coverage for changed files

Filename                                   Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Page/V3/BlobStore.cpp                          374               113    69.79%          39                 3    92.31%         818               209    74.45%         240                90    62.50%
Page/V3/BlobStore.h                              7                 1    85.71%           7                 1    85.71%          25                10    60.00%           0                 0         -
Page/V3/LogFile/LogFilename.cpp                 45                 4    91.11%           1                 0   100.00%          38                 2    94.74%          22                 6    72.73%
Page/V3/LogFile/LogFilename.h                    9                 0   100.00%           3                 0   100.00%          18                 3    83.33%           4                 0   100.00%
Page/V3/LogFile/LogWriter.cpp                   50                 1    98.00%           8                 1    87.50%         109                 8    92.66%          32                 1    96.88%
Page/V3/PageDirectory.cpp                      456                64    85.96%          31                 2    93.55%        1009               183    81.86%         374                83    77.81%
Page/V3/PageDirectory.h                         25                 6    76.00%          25                 6    76.00%         104                21    79.81%           0                 0         -
Page/V3/PageDirectoryFactory.cpp                39                 5    87.18%           4                 0   100.00%         117                15    87.18%          46                 5    89.13%
Page/V3/PageDirectoryFactory.h                   2                 0   100.00%           2                 0   100.00%           8                 0   100.00%           0                 0         -
Page/V3/PageStorageImpl.cpp                     80                22    72.50%          21                 7    66.67%         194                62    68.04%          44                23    47.73%
Page/V3/WAL/WALReader.cpp                       72                10    86.11%           9                 0   100.00%         173                15    91.33%          54                14    74.07%
Page/V3/WAL/WALReader.h                         12                 3    75.00%           4                 1    75.00%          19                 7    63.16%           6                 2    66.67%
Page/V3/WALStore.cpp                            83                48    42.17%           8                 1    87.50%         135                43    68.15%          38                21    44.74%
Page/V3/WALStore.h                               1                 0   100.00%           1                 0   100.00%           3                 0   100.00%           0                 0         -
Page/V3/tests/gtest_blob_store.cpp            3589               596    83.39%          17                 0   100.00%         694                 0   100.00%        1114               525    52.87%
Page/V3/tests/gtest_page_directory.cpp        8833              1575    82.17%          50                 0   100.00%        1635                 7    99.57%        2774              1405    49.35%
Page/V3/tests/gtest_wal_store.cpp             1948               260    86.65%          12                 0   100.00%         465                13    97.20%         646               314    51.39%
tests/TiFlashStorageTestBasic.h                 35                 7    80.00%           7                 0   100.00%          67                19    71.64%          22                11    50.00%
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                        15660              2715    82.66%         249                22    91.16%        5631               617    89.04%        5416              2500    53.84%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17070      9588             43.83%    192104  97209        49.40%

full coverage report (for internal network access only)

@jiaqizho @JaySon-Huang
Update dbms/src/Storages/Page/V3/WAL/WALReader.cpp
7e760cc 
Co-authored-by: JaySon <tshent@qq.com>
JaySon-Huang
JaySon-Huang approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 30, 2022
@jiaqizho jiaqizho requested a review from CalvinNeo March 31, 2022 02:50
CalvinNeo
CalvinNeo approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 31, 2022
@jiaqizho
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@jiaqizho: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7e760cc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 31, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 31, 2022

Coverage for changed files

Filename                                   Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Page/V3/BlobStore.cpp                          374               113    69.79%          39                 3    92.31%         818               209    74.45%         240                90    62.50%
Page/V3/BlobStore.h                              7                 1    85.71%           7                 1    85.71%          25                10    60.00%           0                 0         -
Page/V3/LogFile/LogFilename.cpp                 45                 4    91.11%           1                 0   100.00%          38                 2    94.74%          22                 6    72.73%
Page/V3/LogFile/LogFilename.h                    9                 0   100.00%           3                 0   100.00%          18                 3    83.33%           4                 0   100.00%
Page/V3/LogFile/LogWriter.cpp                   50                 1    98.00%           8                 1    87.50%         109                 8    92.66%          32                 1    96.88%
Page/V3/PageDirectory.cpp                      456                64    85.96%          31                 2    93.55%        1009               183    81.86%         374                83    77.81%
Page/V3/PageDirectory.h                         25                 6    76.00%          25                 6    76.00%         104                21    79.81%           0                 0         -
Page/V3/PageDirectoryFactory.cpp                39                 5    87.18%           4                 0   100.00%         117                15    87.18%          46                 5    89.13%
Page/V3/PageDirectoryFactory.h                   2                 0   100.00%           2                 0   100.00%           8                 0   100.00%           0                 0         -
Page/V3/PageStorageImpl.cpp                     87                25    71.26%          21                 7    66.67%         204                65    68.14%          46                24    47.83%
Page/V3/WAL/WALReader.cpp                       72                10    86.11%           9                 0   100.00%         173                15    91.33%          54                14    74.07%
Page/V3/WAL/WALReader.h                         12                 3    75.00%           4                 1    75.00%          19                 7    63.16%           6                 2    66.67%
Page/V3/WALStore.cpp                            83                48    42.17%           8                 1    87.50%         135                43    68.15%          38                21    44.74%
Page/V3/WALStore.h                               1                 0   100.00%           1                 0   100.00%           3                 0   100.00%           0                 0         -
Page/V3/tests/gtest_blob_store.cpp            3589               596    83.39%          17                 0   100.00%         694                 0   100.00%        1114               525    52.87%
Page/V3/tests/gtest_page_directory.cpp        8833              1575    82.17%          50                 0   100.00%        1635                 7    99.57%        2774              1405    49.35%
Page/V3/tests/gtest_wal_store.cpp             1948               260    86.65%          12                 0   100.00%         465                13    97.20%         646               314    51.39%
tests/TiFlashStorageTestBasic.h                 35                 7    80.00%           7                 0   100.00%          67                19    71.64%          22                11    50.00%
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                        15667              2718    82.65%         249                22    91.16%        5641               620    89.01%        5418              2501    53.84%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17073      9592             43.82%    192148  97225        49.40%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 0df8f94 into pingcap:master Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalvinNeo CalvinNeo CalvinNeo approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jiaqizho @ti-chi-bot @sre-bot @JaySon-Huang @CalvinNeo