Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gtests for MPPTunnel #4553

Merged
merged 5 commits into from
Apr 18, 2022
Merged

Add gtests for MPPTunnel #4553

merged 5 commits into from
Apr 18, 2022

Conversation

yibin87
Copy link
Contributor

@yibin87 yibin87 commented Apr 1, 2022

Signed-off-by: yibin huyibin@pingcap.com

What problem does this PR solve?

Issue Number: close #4481

Problem Summary:

What is changed and how it works?

Check List

Tests

  • [ x] Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@yibin87
Add gtests for MPPTunnel
13d5d70 
Signed-off-by: yibin <huyibin@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 1, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bestwoody
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 1, 2022
@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 1, 2022
@yibin87 yibin87 requested a review from windtalker April 1, 2022 05:43
@yibin87
Copy link
Contributor Author

yibin87 commented Apr 1, 2022

Previous PR seems breaks when TiFlash make public, so create this new one. And add is_local and is_async tests.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 1, 2022
@yibin87
Fix unwanted changes
cef8558 
Signed-off-by: yibin <huyibin@pingcap.com>
windtalker
windtalker reviewed Apr 13, 2022
View reviewed changes
dbms/src/Flash/Mpp/tests/gtest_mpptunnel.cpp Outdated
{
bool write(const mpp::MPPDataPacket & packet) override
{
write_packet_vec.push_back(packet.data());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just return false without saving the packet?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid unused paremeter, anyway, I'll remove so to see if format complain anything.

dbms/src/Flash/Mpp/tests/gtest_mpptunnel.cpp Outdated Show resolved Hide resolved
dbms/src/Flash/Mpp/tests/gtest_mpptunnel.cpp Outdated
data_packet_ptr->set_data("First");
mpp_tunnel_ptr->write(*data_packet_ptr);
std::this_thread::sleep_for(std::chrono::milliseconds(1000)); // wait for sendJob thread to write data
mpp_tunnel_ptr->close("Canceled");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not call close with empty string? This is the normal case and no error message will be written to the writer.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I think close will blocked until the sendJob thread finishes, so no need to sleep?

dbms/src/Flash/Mpp/tests/gtest_mpptunnel.cpp
data_packet_ptr->set_data("First");
mpp_tunnel_ptr->write(*data_packet_ptr, true);
std::this_thread::sleep_for(std::chrono::milliseconds(1000)); // wait for sendJob thread to write data
mpp_tunnel_ptr->waitForFinish();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If waitForFinish is called, then there is no need to sleep for the sendJob thread?

dbms/src/Flash/Mpp/tests/gtest_mpptunnel.cpp
data_packet_ptr->set_data("First");
mpp_tunnel_ptr->write(*data_packet_ptr);
std::this_thread::sleep_for(std::chrono::milliseconds(1000)); // wait for sendJob thread to write data
mpp_tunnel_ptr->writeDone();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto, no need to sleep

dbms/src/Flash/Mpp/tests/gtest_mpptunnel.cpp Outdated
auto data_packet_ptr = std::make_unique<mpp::MPPDataPacket>();
data_packet_ptr->set_data("First");
mpp_tunnel_ptr->write(*data_packet_ptr);
std::this_thread::sleep_for(std::chrono::milliseconds(1000)); // wait for sendJob thread to write data
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

@yibin87
Changes to apply comments
b907100 
Signed-off-by: yibin <huyibin@pingcap.com>
@yibin87 yibin87 requested a review from windtalker April 18, 2022 05:22
@yibin87
Fix format issue
f8a5295 
Signed-off-by: yibin <huyibin@pingcap.com>
windtalker
windtalker approved these changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 18, 2022
@yibin87
Copy link
Contributor Author

yibin87 commented Apr 18, 2022

/merge

@ti-chi-bot
Copy link
Member

@yibin87: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f8a5295

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 18, 2022
@ti-chi-bot
Copy link
Member

@yibin87: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@yibin87
Copy link
Contributor Author

yibin87 commented Apr 18, 2022

/run-unit-test

@sre-bot
Copy link
Collaborator

sre-bot commented Apr 18, 2022

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
MPPTunnel.cpp                     279                81    70.97%          17                 1    94.12%         244                29    88.11%         124                45    63.71%
MPPTunnel.h                         9                 4    55.56%           9                 4    55.56%          18                 4    77.78%           0                 0         -
tests/gtest_mpptunnel.cpp        1641               458    72.09%          50                 0   100.00%         445                 0   100.00%         458               238    48.03%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                            1929               543    71.85%          76                 5    93.42%         707                33    95.33%         582               283    51.37%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17130      9491             44.59%    192825  96222        50.10%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 605ddc0 into pingcap:master Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bestwoody bestwoody bestwoody approved these changes

@windtalker windtalker windtalker approved these changes

@fuzhe1989 fuzhe1989 Awaiting requested review from fuzhe1989

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add GTest for MPPTunnel
5 participants
@yibin87 @ti-chi-bot @sre-bot @windtalker @bestwoody