Add a background metrics for both v2 and v3 #4593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
jiaqizho
changed the title
ti-chi-bot
added
the
do-not-merge/work-in-progress
ti-chi-bot
added
size/M
jiaqizho
commented
Apr 7, 2022
|
/run-all-tests |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
jiaqizho
changed the title
ti-chi-bot
removed
the
do-not-merge/work-in-progress
|
|
JaySon-Huang
reviewed
Apr 8, 2022
ti-chi-bot
added
size/L
|
/run-all-tests |
lidezhu
reviewed
Apr 15, 2022
| @@ -488,7 +492,7 @@ PageFile::MetaMergingReaderPtr PageFile::MetaMergingReader::createFrom(PageFile | |||
| // Try to initiallize access to meta, read the whole metadata to memory. | |||
| // Status -> Finished if metadata size is zero. | |||
| // -> Opened if metadata successfully load from disk. | |||
| void PageFile::MetaMergingReader::initialize(std::optional<size_t> max_meta_offset, const ReadLimiterPtr & read_limiter) | |||
| void PageFile::MetaMergingReader::initialize(std::optional<size_t> max_meta_offset, const ReadLimiterPtr & read_limiter, const bool background = false) | |||
There was a problem hiding this comment.
Suggested change
| void PageFile::MetaMergingReader::initialize(std::optional<size_t> max_meta_offset, const ReadLimiterPtr & read_limiter, const bool background = false) | |
| void PageFile::MetaMergingReader::initialize(std::optional<size_t> max_meta_offset, const ReadLimiterPtr & read_limiter, bool background = false) |
There was a problem hiding this comment.
why remove const here?
There was a problem hiding this comment.
const on arguments that is passed by value is unuseful. But is't not a big deal.
| @@ -184,7 +190,7 @@ class PageFile : public Allocator<false> | |||
| } | |||
|
|
|||
| private: | |||
| void initialize(std::optional<size_t> max_meta_offset, const ReadLimiterPtr & read_limiter); | |||
| void initialize(std::optional<size_t> max_meta_offset, const ReadLimiterPtr & read_limiter, const bool background = false); | |||
There was a problem hiding this comment.
Suggested change
| void initialize(std::optional<size_t> max_meta_offset, const ReadLimiterPtr & read_limiter, const bool background = false); | |
| void initialize(std::optional<size_t> max_meta_offset, const ReadLimiterPtr & read_limiter, bool background = false); |
|
/run-all-tests |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
lidezhu
approved these changes
Apr 15, 2022
ti-chi-bot
added
status/LGT2
|
/merge |
|
@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: ac2d71c
|
ti-chi-bot
added
the
status/can-merge
|
@jiaqizho: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #3594
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note