refine `SubqueryForSet` #4623

SeaRise · 2022-04-11T10:47:12Z

What problem does this PR solve?

Issue Number: ref #4118

Problem Summary:

What is changed and how it works?

move SubqueryForSet from ExpressionAnalyzer.h to SubqueryForSet.h
move subqueries_for_sets from InterpreterDAG to DAGContext

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

None

ti-chi-bot · 2022-04-11T10:47:13Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

windtalker
ywqzzy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

SeaRise · 2022-04-12T03:02:01Z

/run-all-tests

sre-bot · 2022-04-12T03:26:29Z

Coverage for changed files

Filename                                           Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DataStreams/CreatingSetsBlockInputStream.cpp           183               183     0.00%           9                 9     0.00%         197               197     0.00%         112               112     0.00%
DataStreams/CreatingSetsBlockInputStream.h              15                15     0.00%           6                 6     0.00%          29                29     0.00%           8                 8     0.00%
Flash/Coprocessor/DAGContext.cpp                        95                71    25.26%          26                18    30.77%         211               174    17.54%          66                56    15.15%
Flash/Coprocessor/DAGContext.h                          31                13    58.06%          24                12    50.00%          72                30    58.33%           8                 3    62.50%
Flash/Coprocessor/DAGQueryBlockInterpreter.cpp         390               390     0.00%          45                45     0.00%         878               878     0.00%         312               312     0.00%
Flash/Coprocessor/DAGQueryBlockInterpreter.h             2                 2     0.00%           2                 2     0.00%           2                 2     0.00%           0                 0         -
Flash/Coprocessor/InterpreterDAG.cpp                    19                19     0.00%           4                 4     0.00%          51                51     0.00%          16                16     0.00%
Flash/Coprocessor/InterpreterDAG.h                       1                 1     0.00%           1                 1     0.00%           1                 1     0.00%           0                 0         -
Interpreters/ExpressionAnalyzer.h                        4                 4     0.00%           4                 4     0.00%           4                 4     0.00%           0                 0         -
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                  740               698     5.68%         121               101    16.53%        1445              1366     5.47%         522               507     2.87%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17023      9510             44.13%    191889  96433        49.75%

full coverage report (for internal network access only)

dbms/src/Flash/Coprocessor/InterpreterDAG.cpp

SeaRise · 2022-04-12T04:13:53Z

/run-all-tests

sre-bot · 2022-04-12T05:05:52Z

Coverage for changed files

Filename                                           Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DataStreams/CreatingSetsBlockInputStream.cpp           183               183     0.00%           9                 9     0.00%         197               197     0.00%         112               112     0.00%
DataStreams/CreatingSetsBlockInputStream.h              15                15     0.00%           6                 6     0.00%          29                29     0.00%           8                 8     0.00%
Flash/Coprocessor/DAGContext.cpp                        95                71    25.26%          26                18    30.77%         211               174    17.54%          66                56    15.15%
Flash/Coprocessor/DAGContext.h                          31                13    58.06%          24                12    50.00%          72                30    58.33%           8                 3    62.50%
Flash/Coprocessor/DAGQueryBlockInterpreter.cpp         390               390     0.00%          45                45     0.00%         878               878     0.00%         312               312     0.00%
Flash/Coprocessor/DAGQueryBlockInterpreter.h             2                 2     0.00%           2                 2     0.00%           2                 2     0.00%           0                 0         -
Flash/Coprocessor/InterpreterDAG.cpp                    19                19     0.00%           4                 4     0.00%          51                51     0.00%          16                16     0.00%
Flash/Coprocessor/InterpreterDAG.h                       1                 1     0.00%           1                 1     0.00%           1                 1     0.00%           0                 0         -
Interpreters/ExpressionAnalyzer.h                        4                 4     0.00%           4                 4     0.00%           4                 4     0.00%           0                 0         -
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                  740               698     5.68%         121               101    16.53%        1445              1366     5.47%         522               507     2.87%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17023      9510             44.13%    191889  96428        49.75%

full coverage report (for internal network access only)

dbms/src/Flash/Coprocessor/InterpreterDAG.cpp

dbms/src/Interpreters/SubqueryForSet.h

SeaRise · 2022-04-13T09:39:39Z

/run-integration-test

SeaRise · 2022-04-14T02:20:00Z

/run-integration-test

windtalker

LGTM

SeaRise · 2022-04-18T02:10:47Z

/merge

ti-chi-bot · 2022-04-18T02:10:48Z

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-04-18T02:10:50Z

This pull request has been accepted and is ready to merge.

Commit hash: b097fa1

ti-chi-bot · 2022-04-18T02:11:03Z

@SeaRise: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

sre-bot · 2022-04-18T02:34:01Z

Coverage for changed files

Filename                                           Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DataStreams/CreatingSetsBlockInputStream.h              14                14     0.00%           5                 5     0.00%          26                26     0.00%           8                 8     0.00%
Flash/Coprocessor/DAGContext.cpp                       100                71    29.00%          27                19    29.63%         227               180    20.70%          72                58    19.44%
Flash/Coprocessor/DAGContext.h                          33                15    54.55%          26                14    46.15%          77                34    55.84%           8                 3    62.50%
Flash/Coprocessor/DAGQueryBlockInterpreter.cpp         390               390     0.00%          45                45     0.00%         878               878     0.00%         312               312     0.00%
Flash/Coprocessor/DAGQueryBlockInterpreter.h             2                 2     0.00%           2                 2     0.00%           2                 2     0.00%           0                 0         -
Flash/Coprocessor/InterpreterDAG.cpp                    17                17     0.00%           4                 4     0.00%          50                50     0.00%          12                12     0.00%
Flash/Coprocessor/InterpreterDAG.h                       1                 1     0.00%           1                 1     0.00%           1                 1     0.00%           0                 0         -
Interpreters/ExpressionAnalyzer.h                        4                 4     0.00%           4                 4     0.00%           4                 4     0.00%           0                 0         -
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                  561               514     8.38%         114                94    17.54%        1265              1175     7.11%         412               393     4.61%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17078      9519             44.26%    192376  96505        49.84%

full coverage report (for internal network access only)

update

880013d

ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Apr 11, 2022

SeaRise added 6 commits April 11, 2022 18:51

y

35b2acb

fix

036b391

refactor

491e63b

import

cb39af7

u

5804827

fix

840e2c1

SeaRise changed the title ~~refine SubqueryForSet and CreatingSetBlockInputStream~~ [WIP] refine SubqueryForSet and CreatingSetBlockInputStream Apr 12, 2022

ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 12, 2022

SeaRise commented Apr 12, 2022

View reviewed changes

dbms/src/Flash/Coprocessor/InterpreterDAG.cpp Outdated Show resolved Hide resolved

Update dbms/src/Flash/Coprocessor/InterpreterDAG.cpp

0e37233

SeaRise changed the title ~~[WIP] refine SubqueryForSet and CreatingSetBlockInputStream~~ refine SubqueryForSet and CreatingSetBlockInputStream Apr 12, 2022

ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 12, 2022

SeaRise requested review from windtalker, fuzhe1989, ywqzzy and LittleFall April 12, 2022 05:47

ywqzzy reviewed Apr 12, 2022

View reviewed changes

dbms/src/Flash/Coprocessor/InterpreterDAG.cpp Show resolved Hide resolved

dbms/src/Flash/Coprocessor/InterpreterDAG.cpp Outdated Show resolved Hide resolved

address comment

cf7fe42

SeaRise commented Apr 12, 2022

View reviewed changes

dbms/src/Interpreters/SubqueryForSet.h Show resolved Hide resolved

address comments

36eb94d

SeaRise changed the title ~~refine SubqueryForSet and CreatingSetBlockInputStream~~ refine SubqueryForSet Apr 13, 2022

SeaRise requested a review from ywqzzy April 13, 2022 10:49

Merge branch 'master' into refine_subquery_set

b097fa1

ywqzzy approved these changes Apr 14, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 14, 2022

windtalker approved these changes Apr 18, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 18, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 18, 2022

Merge branch 'master' into refine_subquery_set

8efc177

ti-chi-bot merged commit 66f45c7 into pingcap:master Apr 18, 2022

SeaRise deleted the refine_subquery_set branch April 18, 2022 02:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refine `SubqueryForSet` #4623

refine `SubqueryForSet` #4623

SeaRise commented Apr 11, 2022 •

edited

Loading

ti-chi-bot commented Apr 11, 2022 •

edited

Loading

SeaRise commented Apr 12, 2022

sre-bot commented Apr 12, 2022

SeaRise commented Apr 12, 2022

sre-bot commented Apr 12, 2022

SeaRise commented Apr 13, 2022

SeaRise commented Apr 14, 2022

windtalker left a comment

SeaRise commented Apr 18, 2022

ti-chi-bot commented Apr 18, 2022

ti-chi-bot commented Apr 18, 2022

ti-chi-bot commented Apr 18, 2022

sre-bot commented Apr 18, 2022

refine SubqueryForSet #4623

refine SubqueryForSet #4623

Conversation

SeaRise commented Apr 11, 2022 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Apr 11, 2022 • edited Loading

SeaRise commented Apr 12, 2022

sre-bot commented Apr 12, 2022

Coverage for changed files

Coverage summary

SeaRise commented Apr 12, 2022

sre-bot commented Apr 12, 2022

Coverage for changed files

Coverage summary

SeaRise commented Apr 13, 2022

SeaRise commented Apr 14, 2022

windtalker left a comment

Choose a reason for hiding this comment

SeaRise commented Apr 18, 2022

ti-chi-bot commented Apr 18, 2022

ti-chi-bot commented Apr 18, 2022

ti-chi-bot commented Apr 18, 2022

sre-bot commented Apr 18, 2022

Coverage for changed files

Coverage summary

refine `SubqueryForSet` #4623

refine `SubqueryForSet` #4623

SeaRise commented Apr 11, 2022 •

edited

Loading

ti-chi-bot commented Apr 11, 2022 •

edited

Loading