Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] refine executeAggregation and handleExchangeSender #4629

Closed
wants to merge 13 commits into from
Closed

[WIP] refine executeAggregation and handleExchangeSender #4629

wants to merge 13 commits into from

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Apr 12, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #4118

Problem Summary:

What is changed and how it works?

  • add AggregationInterpreterHelper and ExchangeSenderInterpreterHelper to refine the code of handleAgg and handExchangeSender
  • move fillArgColumnNumbers from executeAggregate to analyzeExpression

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 12, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 12, 2022

/run-all-tests

@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 12, 2022

/run-all-tests

@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 12, 2022

/run-unit-test

@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 13, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Apr 13, 2022

Coverage for changed files

Filename                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
AggregationInterpreterHelper.cpp             38                38     0.00%           5                 5     0.00%          59                59     0.00%          36                36     0.00%
DAGQueryBlockInterpreter.cpp                341               341     0.00%          43                43     0.00%         821               821     0.00%         264               264     0.00%
ExchangeSenderInterpreterHelper.cpp          14                14     0.00%           1                 1     0.00%          28                28     0.00%          12                12     0.00%
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                       393               393     0.00%          49                49     0.00%         908               908     0.00%         312               312     0.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17027      9514             44.12%    191927  96457        49.74%

full coverage report (for internal network access only)

@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 13, 2022

/run-integration-test

@SeaRise SeaRise changed the title refine executeAggregation and handleExchangeSender [WIP] refine executeAggregation and handleExchangeSender Apr 13, 2022
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 13, 2022
@SeaRise SeaRise changed the title [WIP] refine executeAggregation and handleExchangeSender refine executeAggregation and handleExchangeSender Apr 13, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 13, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 14, 2022

/run-integration-test

1 similar comment
@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 14, 2022

/run-integration-test

@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 14, 2022

/run-integration-test

@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 15, 2022

/run-integration-test

@SeaRise SeaRise changed the title refine executeAggregation and handleExchangeSender [WIP] refine executeAggregation and handleExchangeSender Apr 15, 2022
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 15, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 16, 2022

/run-integration-test

@SeaRise SeaRise closed this Apr 16, 2022
@SeaRise SeaRise reopened this Apr 16, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Apr 16, 2022

Coverage for changed files

Filename                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
AggregationInterpreterHelper.cpp             39                39     0.00%           6                 6     0.00%          57                57     0.00%          36                36     0.00%
DAGQueryBlockInterpreter.cpp                341               341     0.00%          43                43     0.00%         821               821     0.00%         264               264     0.00%
DAGQueryBlockInterpreter.h                    2                 2     0.00%           2                 2     0.00%           2                 2     0.00%           0                 0         -
ExchangeSenderInterpreterHelper.cpp          25                25     0.00%           1                 1     0.00%          28                28     0.00%          16                16     0.00%
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                       407               407     0.00%          52                52     0.00%         908               908     0.00%         316               316     0.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17080      9521             44.26%    192397  96509        49.84%

full coverage report (for internal network access only)

@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 18, 2022

/run-integration-test

@SeaRise SeaRise closed this Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SeaRise @ti-chi-bot @sre-bot