Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle grpc/protobuf curl zlib ssl in release-5.4 (#3896) (#3901) (#3974) (#3987) #4689

Merged
merged 11 commits into from
Apr 22, 2022
Merged

Bundle grpc/protobuf curl zlib ssl in release-5.4 (#3896) (#3901) (#3974) (#3987) #4689

merged 11 commits into from
Apr 22, 2022

Conversation

solotzg
Copy link
Contributor

@solotzg solotzg commented Apr 18, 2022

What problem does this PR solve?

Issue Number: close #4196

Problem Summary:

What is changed and how it works?

Reference: grpc/grpc#23144

Change to use boringssl.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the potential crash issue that occurs when TLS is enabled

@solotzg solotzg added type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR. labels Apr 18, 2022
@solotzg solotzg added this to the v5.4.1 milestone Apr 18, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 18, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CalvinNeo
  • zanmato1984

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 18, 2022
@solotzg solotzg mentioned this pull request Apr 18, 2022
Closed
12 tasks
@solotzg
Copy link
Contributor Author

solotzg commented Apr 18, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Apr 18, 2022

lines: 43.3% (49808 out of 115139)
branches: 6.4% (81421 out of 1263928)

@JaySon-Huang JaySon-Huang mentioned this pull request Apr 19, 2022
Merged
12 tasks
@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 21, 2022
zanmato1984
zanmato1984 approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 21, 2022
@solotzg solotzg requested a review from LittleFall April 22, 2022 01:46
@solotzg
Copy link
Contributor Author

solotzg commented Apr 22, 2022

/merge

@ti-chi-bot
Copy link
Member

@solotzg: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@solotzg: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Apr 22, 2022

lines: 43.3% (49815 out of 115143)
branches: 6.4% (81427 out of 1264034)

CalvinNeo
CalvinNeo approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 22, 2022
@solotzg
Copy link
Contributor Author

solotzg commented Apr 22, 2022

/merge

@ti-chi-bot
Copy link
Member

@solotzg: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 47f9492

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 22, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Apr 22, 2022

lines: 43.2% (49812 out of 115180)
branches: 6.4% (81419 out of 1264195)

@ti-chi-bot ti-chi-bot merged commit 5d8e89f into pingcap:release-5.4 Apr 22, 2022
@solotzg solotzg deleted the release-5.4 branch April 22, 2022 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalvinNeo CalvinNeo CalvinNeo approved these changes

@zanmato1984 zanmato1984 zanmato1984 approved these changes

@SchrodingerZhu SchrodingerZhu Awaiting requested review from SchrodingerZhu

@LittleFall LittleFall Awaiting requested review from LittleFall

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR.
Projects
None yet
Milestone
v5.4.1
Development

Successfully merging this pull request may close these issues.
6 participants
@solotzg @ti-chi-bot @sre-bot @zanmato1984 @CalvinNeo @VelocityLight