-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reuse old index file format for empty dmfile and just ignore it's size in statistical data #4711
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
…e in statistical data
a97fce9
to
4c5eec9
Compare
/run-all-tests |
Coverage for changed files
Coverage summary
full coverage report (for internal network access only) |
/merge |
@lidezhu: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: dc2e99a
|
Coverage for changed files
Coverage summary
full coverage report (for internal network access only) |
What problem does this PR solve?
Issue Number: close #4708
Problem Summary:
In this pr #4500, we avoid write data into minmax index file for emtpy dmfile. But this kind of dmfile cannot be recogonized by older version. So after degrading, tiflash fails.
What is changed and how it works?
Reuse old index file format and just ignore the size written into minmax index file in this case.
Check List
Tests
stable_siz_on_disk
is 0 for empty segments;Side effects
Documentation
Release note