Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reuse old index file format for empty dmfile and just ignore it's size in statistical data #4711

Merged
merged 3 commits into from
Apr 20, 2022

Conversation

lidezhu
Copy link
Contributor

@lidezhu lidezhu commented Apr 19, 2022

What problem does this PR solve?

Issue Number: close #4708

Problem Summary:
In this pr #4500, we avoid write data into minmax index file for emtpy dmfile. But this kind of dmfile cannot be recogonized by older version. So after degrading, tiflash fails.

What is changed and how it works?

Reuse old index file format and just ignore the size written into minmax index file in this case.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  1. Test that stable_siz_on_disk is 0 for empty segments;
  2. Test that after this fix the master branch can be degraded to ver6.0.0;
    Side effects
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 19, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JinheLin
  • Lloyd-Pottiger

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/needs-triage-completed and removed do-not-merge/needs-linked-issue do-not-merge/needs-triage-completed labels Apr 19, 2022
@lidezhu
Copy link
Contributor Author

lidezhu commented Apr 19, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Apr 19, 2022

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DMFileWriter.cpp                  103                 8    92.23%          15                 0   100.00%         438                18    95.89%          70                 9    87.14%
DMFileWriter.h                     24                 1    95.83%          14                 1    92.86%          37                 3    91.89%           6                 0   100.00%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                             127                 9    92.91%          29                 1    96.55%         475                21    95.58%          76                 9    88.16%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17132      9492             44.59%    192843  96244        50.09%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 20, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 20, 2022
@lidezhu
Copy link
Contributor Author

lidezhu commented Apr 20, 2022

/merge

@ti-chi-bot
Copy link
Member

@lidezhu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: dc2e99a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 20, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Apr 20, 2022

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DMFileWriter.cpp                  103                 8    92.23%          15                 0   100.00%         438                18    95.89%          70                 9    87.14%
DMFileWriter.h                     24                 1    95.83%          14                 1    92.86%          37                 3    91.89%           6                 0   100.00%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                             127                 9    92.91%          29                 1    96.55%         475                21    95.58%          76                 9    88.16%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17132      9492             44.59%    192856  96262        50.09%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 8a2e62d into pingcap:master Apr 20, 2022
@lidezhu lidezhu deleted the fix-minmax-write branch April 20, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tiflash crash and restart all the way
5 participants