Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine handle agg and exchange sender #4721

Merged

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Apr 20, 2022

What problem does this PR solve?

Issue Number: ref #4118

Problem Summary:

What is changed and how it works?

  • add AggregationInterpreterHelper and ExchangeSenderInterpreterHelper to refine the code of executeAgg and handleExchangeSender

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 20, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • windtalker
  • ywqzzy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 20, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 20, 2022

/run-integration-test

@SeaRise SeaRise requested a review from ywqzzy April 21, 2022 06:26
@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 21, 2022

/run-integration-test

Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 25, 2022
Copy link
Contributor

@ywqzzy ywqzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 25, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 25, 2022

/merge

@ti-chi-bot
Copy link
Member

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ebcdd85

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 25, 2022
@ti-chi-bot
Copy link
Member

@SeaRise: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 25, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Apr 25, 2022

Coverage for changed files

Filename                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
AggregationInterpreterHelper.cpp             40                40     0.00%           7                 7     0.00%          58                58     0.00%          36                36     0.00%
DAGQueryBlockInterpreter.cpp                370               351     5.14%          49                37    24.49%         873               791     9.39%         282               273     3.19%
DAGQueryBlockInterpreter.h                    2                 0   100.00%           2                 0   100.00%           2                 0   100.00%           0                 0         -
ExchangeSenderInterpreterHelper.cpp          20                20     0.00%           2                 2     0.00%          38                38     0.00%          18                18     0.00%
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                       432               411     4.86%          60                46    23.33%         971               887     8.65%         336               327     2.68%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17257      9415             45.44%    194309  95820        50.69%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit c751073 into pingcap:master Apr 25, 2022
@SeaRise SeaRise deleted the refine_handle_agg_and_exchange_sender branch April 25, 2022 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants