Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: frame total size include header for indices #4754

Merged
merged 3 commits into from
Apr 26, 2022

Conversation

SchrodingerZhu
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #4752
This was not previously triggered because index files should be very small.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 25, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hehechen
  • lidezhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 25, 2022
@SchrodingerZhu SchrodingerZhu added the type/bugfix This PR fixes a bug. label Apr 25, 2022
@SchrodingerZhu
Copy link
Contributor Author

/run-all-tests

1 similar comment
@SchrodingerZhu
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 25, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Apr 25, 2022

Coverage for changed files

Filename                                                                                                            Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Storages/DeltaMerge/File/DMFilePackFilter.h         123                15    87.80%          12                 1    91.67%         202                 8    96.04%          88                16    81.82%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                                   123                15    87.80%          12                 1    91.67%         202                 8    96.04%          88                16    81.82%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17257      9415             45.44%    194309  95832        50.68%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 25, 2022
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 Type: Need cherry pick to release-6.0 and removed do-not-merge/needs-triage-completed labels Apr 26, 2022
@SchrodingerZhu
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@SchrodingerZhu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 14e42c5

@flowbehappy
Copy link
Contributor

@SchrodingerZhu I think we should make a UT for this case.

@sre-bot
Copy link
Collaborator

sre-bot commented Apr 26, 2022

Coverage for changed files

Filename                                                                                                            Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Storages/DeltaMerge/File/DMFilePackFilter.h         123                15    87.80%          12                 1    91.67%         202                 8    96.04%          88                16    81.82%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                                   123                15    87.80%          12                 1    91.67%         202                 8    96.04%          88                16    81.82%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18055      10152            43.77%    200021  100949       49.53%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 0e1a373 into master Apr 26, 2022
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Apr 26, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4766.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Apr 26, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4767.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Apr 26, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4768.

@JaySon-Huang JaySon-Huang deleted the schrodingerzhu/fix/index-calculation branch April 28, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 Type: Need cherry pick to release-6.0 release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MinMaxIndex::read may throw exception if index_file_size is 1048592
6 participants