Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add pagestorage v3 design doc #4804

Merged
merged 26 commits into from
May 18, 2022
Merged

doc: add pagestorage v3 design doc #4804

merged 26 commits into from
May 18, 2022

Conversation

jiaqizho
Copy link
Contributor

@jiaqizho jiaqizho commented Apr 28, 2022 •
edited by JaySon-Huang
Loading

What problem does this PR solve?

Issue Number: ref #3594

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 28, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • flowbehappy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 28, 2022
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. do-not-merge/needs-linked-issue labels May 17, 2022
@jiaqizho jiaqizho changed the title [DNM]doc: add v3 design into design doc of pagestorage doc: add v3 design into design doc of pagestorage May 17, 2022
@jiaqizho
Copy link
Contributor Author

@flowbehappy @JaySon-Huang PTAL

@JaySon-Huang JaySon-Huang changed the title doc: add v3 design into design doc of pagestorage doc: add pagestorage v3 design doc May 17, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 18, 2022
JaySon-Huang and others added 2 commits May 18, 2022 15:13
@JaySon-Huang @shichun-0415
Apply suggestions from code review
bbf18a7 
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
@JaySon-Huang @shichun-0415
Apply suggestions from code review
403a7a6 
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
shichun-0415
shichun-0415 reviewed May 18, 2022
View reviewed changes
docs/design/2022-04-28-architecture-of-storage-engine-pagestorage.md Outdated Show resolved Hide resolved
docs/design/2022-04-28-architecture-of-storage-engine-pagestorage.md Outdated Show resolved Hide resolved
docs/design/2022-04-28-architecture-of-storage-engine-pagestorage.md Outdated Show resolved Hide resolved
docs/design/2022-04-28-architecture-of-storage-engine-pagestorage.md Outdated Show resolved Hide resolved
docs/design/2022-04-28-architecture-of-storage-engine-pagestorage.md Outdated Show resolved Hide resolved
docs/design/2022-04-28-architecture-of-storage-engine-pagestorage.md Outdated Show resolved Hide resolved
docs/design/2022-04-28-architecture-of-storage-engine-pagestorage.md Outdated Show resolved Hide resolved
docs/design/2022-04-28-architecture-of-storage-engine-pagestorage.md Outdated Show resolved Hide resolved
jiaqizho and others added 6 commits May 18, 2022 17:18
@jiaqizho @shichun-0415
Update docs/design/2022-04-28-architecture-of-storage-engine-pagestor…
b3a175e 
…age.md

Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
@jiaqizho @shichun-0415
Update docs/design/2022-04-28-architecture-of-storage-engine-pagestor…
3613ac4 
…age.md

Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
@jiaqizho @shichun-0415
Update docs/design/2022-04-28-architecture-of-storage-engine-pagestor…
4f43f30 
…age.md

Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
@jiaqizho @shichun-0415
Update docs/design/2022-04-28-architecture-of-storage-engine-pagestor…
316bef1 
…age.md

Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
@jiaqizho @shichun-0415
Update docs/design/2022-04-28-architecture-of-storage-engine-pagestor…
2389c40 
…age.md

Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
@jiaqizho @shichun-0415
Update docs/design/2022-04-28-architecture-of-storage-engine-pagestor…
dc16692 
…age.md

Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
JaySon-Huang
JaySon-Huang approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 18, 2022
@jiaqizho
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@jiaqizho: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 617d2eb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 18, 2022
@jiaqizho
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@jiaqizho: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@jiaqizho
Copy link
Contributor Author

/run-all-tests

@JaySon-Huang
Copy link
Contributor

/rebuild

@JaySon-Huang
Copy link
Contributor

/run-integration-test

@ti-chi-bot
Copy link
Member

@jiaqizho: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented May 18, 2022

Coverage for changed files

no c/c++ source change detected

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18156      9792             46.07%    202889  97901        51.75%

full coverage report (for internal network access only)

@jiaqizho
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@jiaqizho: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented May 18, 2022

Coverage for changed files

no c/c++ source change detected

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18156      9792             46.07%    202889  97891        51.75%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 4e783e3 into pingcap:master May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shichun-0415 shichun-0415 shichun-0415 left review comments

@flowbehappy flowbehappy flowbehappy approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jiaqizho @ti-chi-bot @JaySon-Huang @sre-bot @flowbehappy @shichun-0415