Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fail point pause_after_copr_streams_acquired_once #4833

Merged
merged 5 commits into from
May 12, 2022

Conversation

Lloyd-Pottiger
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger commented May 6, 2022

What problem does this PR solve?

Issue Number: close #4868

Problem Summary:

What is changed and how it works?

Add fail point pause_after_copr_streams_acquired_once which is the same as pause_after_copr_streams_acquired but only fail once.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 6, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • SeaRise

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 6, 2022
@Lloyd-Pottiger Lloyd-Pottiger changed the title Add fail point pause_after_copr_streams_acquired_once [DNM]Add fail point pause_after_copr_streams_acquired_once May 6, 2022
@Lloyd-Pottiger Lloyd-Pottiger changed the title [DNM]Add fail point pause_after_copr_streams_acquired_once Add fail point pause_after_copr_streams_acquired_once May 12, 2022
@Lloyd-Pottiger Lloyd-Pottiger changed the title Add fail point pause_after_copr_streams_acquired_once [DNM]Add fail point pause_after_copr_streams_acquired_once May 12, 2022
@jiaqizho
Copy link
Contributor

jiaqizho commented May 12, 2022

@SeaRise
@Lloyd-Pottiger added a pause_after_copr_streams_acquired_once to pause one of query thread. This will help the storage layer to generate a very long stale snapshot. is that make sense to you ?

Diff with pause_after_copr_streams_acquired, pause_after_copr_streams_acquired will pause channel of query, but pause_after_copr_streams_acquired_once will pause once.

@jiaqizho jiaqizho requested a review from SeaRise May 12, 2022 01:58
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2022
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@Lloyd-Pottiger Lloyd-Pottiger changed the title [DNM]Add fail point pause_after_copr_streams_acquired_once Add fail point pause_after_copr_streams_acquired_once May 12, 2022
@Lloyd-Pottiger Lloyd-Pottiger requested review from jiaqizho and JaySon-Huang and removed request for JaySon-Huang May 12, 2022 02:20
@Lloyd-Pottiger
Copy link
Contributor Author

/run-all-tests

@SeaRise SeaRise requested a review from JaySon-Huang May 12, 2022 02:38
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 12, 2022
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 12, 2022
@JaySon-Huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bb29911

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 12, 2022
@ti-chi-bot
Copy link
Member

@Lloyd-Pottiger: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented May 12, 2022

Coverage for changed files

Filename                                        Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/FailPoint.cpp                                440                98    77.73%           6                 0   100.00%          56                 8    85.71%         146                61    58.22%
Flash/Coprocessor/DAGStorageInterpreter.cpp         424               424     0.00%          32                32     0.00%         866               866     0.00%         282               282     0.00%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                               864               522    39.58%          38                32    15.79%         922               874     5.21%         428               343    19.86%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18152      9816             45.92%    202640  98283        51.50%

full coverage report (for internal network access only)

@sre-bot
Copy link
Collaborator

sre-bot commented May 12, 2022

Coverage for changed files

Filename                                        Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/FailPoint.cpp                                440                98    77.73%           6                 0   100.00%          56                 8    85.71%         146                61    58.22%
Flash/Coprocessor/DAGStorageInterpreter.cpp         424               424     0.00%          32                32     0.00%         866               866     0.00%         282               282     0.00%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                               864               522    39.58%          38                32    15.79%         922               874     5.21%         428               343    19.86%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18083      9836             45.61%    201542  98193        51.28%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit c49258b into pingcap:master May 12, 2022
@Lloyd-Pottiger Lloyd-Pottiger deleted the add-a-fail-point branch May 12, 2022 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a fail point to pause one of query thread
6 participants