-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schedule: track the waiting tasks with task ID, and deleted the scheduled task with exceeded state from the waiting tasks queue (#4958) #4974
Conversation
… queue Signed-off-by: fzhedu <fzhedu@gmail.com>
Signed-off-by: fzhedu <fzhedu@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@ti-chi-bot: This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
close as no plan for v6.0.1 |
This is an automated cherry-pick of #4958
… queue
Signed-off-by: fzhedu fzhedu@gmail.com
What problem does this PR solve?
Issue Number: close #4954
Problem Summary:
It is a rule that the lifecycle of a task in the minTSO schedule should be covered by the taskManager.
However, the scheduled tasks due to exceeding the hard limit are not removed from the waiting task queue of the schedule, but will ungester from the taskManager, so the waiting task queue hold the last reference of the task, which break the rule.
to fundamentally prevent from the probem above, we track the waiting tasks with its task ID.
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note