Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable new function test framework by default #5029

Merged
merged 6 commits into from
Jun 1, 2022
Merged

enable new function test framework by default #5029

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7fdacc1
enable new function test framework by default
windtalker May 30, 2022
18fb602
fix
windtalker May 30, 2022
f73b611
address comments
windtalker May 30, 2022
23cd8fa
add more tests
windtalker May 31, 2022
7ddd251
fix
windtalker May 31, 2022
784a365
Merge branch 'master' into use_new_function_unit_test_framework
ti-chi-bot Jun 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 17 additions & 13 deletions dbms/src/Functions/tests/gtest_arithmetic_functions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,10 @@ try
null_or_zero_field.push_back(Field(DecimalField<Decimal128>(0, 0)));

std::vector<Int64> values{10, 2, 20, 8, 10, 0, 30, 8, 16, 4};
/// The precision of a non-zero DecimalField<Decimal128> must not less than minDecimalPrecision<Decimal128>
/// the decimal_128_factor is used to make sure the precision is big enough
Int128 decimal_128_factor = 10000000000;
decimal_128_factor *= 1000000000;
SeaRise marked this conversation as resolved.
Show resolved Hide resolved

const size_t size = 10;

Expand Down Expand Up @@ -172,7 +176,7 @@ try
if (col2_type->onlyNull())
continue;
auto c1 = nullable_decimal_type_1->createColumnConst(size, Null());
auto c2 = col2_type->createColumnConst(size, Field(DecimalField<Decimal128>(2, 0)));
auto c2 = col2_type->createColumnConst(size, Field(DecimalField<Decimal128>(2 * decimal_128_factor, 0)));
auto col1 = ColumnWithTypeAndName(std::move(c1), nullable_decimal_type_1, "col1");
auto col2 = ColumnWithTypeAndName(std::move(c2), col2_type, "col2");
auto result = executeFunction(func_name, {col1, col2});
Expand All @@ -193,7 +197,7 @@ try
continue;
if (!col2_value.isNull() && col2_type->onlyNull())
continue;
auto c1 = col1_type->createColumnConst(size, Field(DecimalField<Decimal128>(100, 2)));
auto c1 = col1_type->createColumnConst(size, Field(DecimalField<Decimal128>(100 * decimal_128_factor, 2)));
auto c2 = col2_type->createColumnConst(size, col2_value);
auto col1 = ColumnWithTypeAndName(std::move(c1), col1_type, "col1");
auto col2 = ColumnWithTypeAndName(std::move(c2), col2_type, "col2");
Expand All @@ -211,11 +215,11 @@ try
{
if (col1_type->onlyNull() || col2_type->onlyNull())
continue;
auto c1 = col1_type->createColumnConst(size, Field(DecimalField<Decimal128>(1000, 2)));
auto c2 = col2_type->createColumnConst(size, Field(DecimalField<Decimal128>(2, 0)));
auto c1 = col1_type->createColumnConst(size, Field(DecimalField<Decimal128>(1000 * decimal_128_factor, 2)));
auto c2 = col2_type->createColumnConst(size, Field(DecimalField<Decimal128>(2 * decimal_128_factor, 0)));
auto col1 = ColumnWithTypeAndName(std::move(c1), col1_type, "col1");
auto col2 = ColumnWithTypeAndName(std::move(c2), col2_type, "col2");
auto res_col = executeFunction(func_name, {col1, col2}).column;
auto res_col = executeFunction(func_name, {col1, col2}, nullptr, false).column;
ASSERT_TRUE(size == res_col->size());
Field res_field;
for (size_t i = 0; i < size; i++)
Expand Down Expand Up @@ -246,7 +250,7 @@ try
if (col1_type->isNullable() && col1_null_map[i])
c1_mutable->insert(Null());
else
c1_mutable->insert(Field(DecimalField<Decimal128>(values[i], 2)));
c1_mutable->insert(Field(DecimalField<Decimal128>(values[i] * decimal_128_factor, 2)));
}
auto c2 = col2_type->createColumnConst(values.size(), col2_value);

Expand All @@ -271,9 +275,9 @@ try
if (col1_type->isNullable() && col1_null_map[i])
c1_mutable->insert(Null());
else
c1_mutable->insert(Field(DecimalField<Decimal128>(values[i], 2)));
c1_mutable->insert(Field(DecimalField<Decimal128>(values[i] * decimal_128_factor, 2)));
}
auto c2 = col2_type->createColumnConst(values.size(), Field(DecimalField<Decimal128>(2, 0)));
auto c2 = col2_type->createColumnConst(values.size(), Field(DecimalField<Decimal128>(2 * decimal_128_factor, 0)));

auto col1 = ColumnWithTypeAndName(std::move(c1_mutable), col1_type, "col1");
auto col2 = ColumnWithTypeAndName(std::move(c2), col2_type, "col2");
Expand Down Expand Up @@ -312,7 +316,7 @@ try
if (col2_type->isNullable() && col2_null_map[i])
c2->insert(Null());
else
c2->insert(Field(DecimalField<Decimal128>(values[i], 2)));
c2->insert(Field(DecimalField<Decimal128>(values[i] * decimal_128_factor, 2)));
}
auto col1 = ColumnWithTypeAndName(std::move(c1), col1_type, "col1");
auto col2 = ColumnWithTypeAndName(std::move(c2), col2_type, "col2");
Expand All @@ -334,14 +338,14 @@ try
if (values[i] != 0)
value *= values[i];
}
auto c1 = col1_type->createColumnConst(size, Field(DecimalField<Decimal128>(value, 2)));
auto c1 = col1_type->createColumnConst(size, Field(DecimalField<Decimal128>(value * decimal_128_factor, 2)));
auto c2 = col2_type->createColumn();
for (size_t i = 0; i < values.size(); i++)
{
if (col2_type->isNullable() && col2_null_map[i])
c2->insert(Null());
else
c2->insert(Field(DecimalField<Decimal128>(values[i], 0)));
c2->insert(Field(DecimalField<Decimal128>(values[i] * decimal_128_factor, 0)));
}
auto col1 = ColumnWithTypeAndName(std::move(c1), col1_type, "col1");
auto col2 = ColumnWithTypeAndName(std::move(c2), col2_type, "col2");
Expand Down Expand Up @@ -377,11 +381,11 @@ try
if (col1_type->isNullable() && col1_null_map[i])
c1->insert(Null());
else
c1->insert(Field(DecimalField<Decimal128>(values[i], 2)));
c1->insert(Field(DecimalField<Decimal128>(values[i] * decimal_128_factor, 2)));
if (col2_type->isNullable() && col2_null_map[i])
c2->insert(Null());
else
c2->insert(Field(DecimalField<Decimal128>(values[i], 0)));
c2->insert(Field(DecimalField<Decimal128>(values[i] * decimal_128_factor, 0)));
}
auto col1 = ColumnWithTypeAndName(std::move(c1), col1_type, "col1");
auto col2 = ColumnWithTypeAndName(std::move(c2), col2_type, "col2");
Expand Down
Loading