Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Planner: Support common physical plans #5143

Merged
merged 63 commits into from
Jul 8, 2022
Merged

Planner: Support common physical plans #5143

merged 63 commits into from
Jul 8, 2022

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Jun 13, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #4739

Problem Summary:

What is changed and how it works?

  • move executeExpression and orderStreams from DAGQueryBlockInterpreter to InterpreterUtils
  • add PhysicalPlan of projection/agg/filter/exchange_(sender/receiver)/limit/topn and add UT
  • fix bug of PhysicalPlanSource
  • update the result of UT gtest_qb_interpreter and gtest_planner_interpreter because the useless ExpressionBlockInputStream has been removed.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    • After pr merged, I would run daily tests.
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 13, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • windtalker
  • yibin87

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 13, 2022
@SeaRise SeaRise requested a review from windtalker July 5, 2022 06:18
windtalker
windtalker approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 7, 2022
yibin87
yibin87 reviewed Jul 8, 2022
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we consider to distinguish PhysicalPlan and PhysicalPlanNode, so that Plan can be more forcused on Tree-level operations, like optimize/transform and remove methods like children later?

yibin87
yibin87 approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 8, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 8, 2022

/run-all-tests

@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 8, 2022

/run-check-license

@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 8, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Jul 8, 2022

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18455      9572             48.13%    207474  96073        53.69%

full coverage report (for internal network access only)

@sre-bot
Copy link
Collaborator

sre-bot commented Jul 8, 2022

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18455      9572             48.13%    207474  96068        53.70%

full coverage report (for internal network access only)

@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 8, 2022

/merge

@ti-chi-bot
Copy link
Member

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 240d6d0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 8, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Jul 8, 2022

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18455      9572             48.13%    207474  96066        53.70%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 07b1b20 into pingcap:planner_refactory Jul 8, 2022
@SeaRise SeaRise mentioned this pull request Jul 11, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yibin87 yibin87 yibin87 approved these changes

@windtalker windtalker windtalker approved these changes

@guo-shaoge guo-shaoge Awaiting requested review from guo-shaoge

@mengxin9014 mengxin9014 Awaiting requested review from mengxin9014

@ywqzzy ywqzzy Awaiting requested review from ywqzzy

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SeaRise @ti-chi-bot @sre-bot @windtalker @yibin87 @ywqzzy