feat: add optimized routines for aarch64 #5231

SchrodingerZhu · 2022-06-24T01:38:06Z

Signed-off-by: SchrodingerZhu i@zhuyi.fan

What problem does this PR solve?

Issue Number: close #5240

Problem Summary:

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

None

ti-chi-bot · 2022-06-24T01:38:07Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

JinheLin
flowbehappy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

SchrodingerZhu · 2022-06-25T18:51:57Z

(tested on aarch64 instances at IDC)

Signed-off-by: SchrodingerZhu <i@zhuyi.fan>

JaySon-Huang · 2022-06-29T09:11:20Z

contrib/arm-optimized-routines-cmake/CMakeLists.txt

+
+file(GLOB TIFLASH_AARCH64_STRING_FILES ${TIFLASH_AOR_DIR}/string/aarch64/*.S)
+add_library(tiflash-aarch64-string STATIC ${TIFLASH_AARCH64_STRING_FILES} src/aor.c)
+target_compile_options(tiflash-aarch64-string PRIVATE -march=armv8-a+sve)


curious about why we need to add -march=armv8-a+sve explicitly? 🤔

it was because in their header file they use _ARM_FEATURE flag to gate the function prototypes.

SchrodingerZhu · 2022-06-29T10:36:37Z

/merge

ti-chi-bot · 2022-06-29T10:36:39Z

@SchrodingerZhu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-06-29T10:36:40Z

This pull request has been accepted and is ready to merge.

Commit hash: 4a0fd3e

sre-bot · 2022-06-29T10:53:15Z

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18405      9638             47.63%    207054  96422        53.43%

full coverage report (for internal network access only)

sre-bot · 2022-06-29T10:53:45Z

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18387      9659             47.47%    206734  96741        53.21%

full coverage report (for internal network access only)

sre-bot · 2022-06-29T12:17:59Z

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18405      9638             47.63%    207054  96444        53.42%

full coverage report (for internal network access only)

…s in README (pingcap#5182) close pingcap#5172, ref pingcap#5178 Enhancement: add a integrated test on DDL module (pingcap#5130) ref pingcap#5129 Revert "Revise default background threads size" (pingcap#5176) close pingcap#5177 chore: remove extra dyn cast (pingcap#5186) close pingcap#5185 Add MPPReceiverSet, which includes ExchangeReceiver and CoprocessorReader (pingcap#5175) ref pingcap#5095 DDL: Use Column Name Instead of Offset to Find the common handle cluster index (pingcap#5166) close pingcap#5154 Add random failpoint in critical paths (pingcap#4876) close pingcap#4807 Segment test framework (pingcap#5150) close pingcap#5151 optimize ps v3 restore (pingcap#5163) ref pingcap#4914 Fix build failed (pingcap#5196) close pingcap#5195 feat: delta tree dispatching (pingcap#5199) close pingcap#5200 feat: introduce specialized API to write fixed length data rapidly (pingcap#5181) close pingcap#5183 Add gtest for Limit, TopN, Projection (pingcap#5187) (pingcap#5188) close pingcap#5187 add `MPPTask::handleError()` (pingcap#5202) ref pingcap#5095 Check result of starting grpc server (pingcap#5257) close pingcap#5255 feat: add optimized routines for aarch64 (pingcap#5231) close pingcap#5240 fix: aarch64-quick-fix (pingcap#5259) close pingcap#5260 Update client-c to support ipv6 (pingcap#5270) close pingcap#5247 upgrade prometheus-cpp to v1.0.1 (pingcap#5279) ref pingcap#2103, close pingcap#5278 Fix README type error (pingcap#5273) ref pingcap#5178 fix(cmake): make sure libc++ is utilized by tiflash-proxy (pingcap#5281) close pingcap#5282 fix the wrong order of execution summary for list based executors (pingcap#5242) close pingcap#5241 Schema: allow loading empty schema diff when the version grows up. (pingcap#5245) close pingcap#5244 Optimize apply speed under heavy write pressure (pingcap#4883) ref pingcap#4728 update proxy to raftstore-proxy-6.2 (pingcap#5287) ref pingcap#4982 Flush segment cache when doing the compaction (pingcap#5284) close pingcap#5179 metrics: Fix incorrect metrics for delta_merge tasks (pingcap#5061) close pingcap#5055 dep: upgrade jemalloc (pingcap#5197) close pingcap#5258 *: TiFlash pagectl/dttool use only-decryption mode (pingcap#5271) close pingcap#5122 suppresion false positive report from tsan (pingcap#5303) close pingcap#5088 Refine test framework code and tests (pingcap#5261) close pingcap#5262 feat: add logical cpu cores and memory into grafana (pingcap#5124) close pingcap#3821 Implement TimeToSec function push down (pingcap#5235) close pingcap#5116 feat: implement shiftRight function push down (pingcap#5156) close pingcap#5100 schema : make update to partition tables when 'set tiflash replica' (pingcap#5267) close pingcap#5266 Replace initializer_list with vector for planner test framework (pingcap#5307) close pingcap#5295 KVStore: decouple flush region and CompactLog with a new FFI fn_try_flush_data (pingcap#5283) ref pingcap#5170 refine error message in mpptask (pingcap#5304) ref pingcap#5095 Implement ReverseUTF8/Reverse function push down (pingcap#5233) close pingcap#5111 Optimize comparision for collation `UTF8_BIN` and `UTF8MB4_BIN` (pingcap#5299) ref pingcap#5294 feat : support set tiflash mode ddl action (pingcap#5256) ref pingcap#5252 Add non-blocking functions for MPMCQueue (pingcap#5311) close pingcap#5310 add random segment test for CI weekly (pingcap#5300) close pingcap#5301 *: tidy FunctionString.cpp (pingcap#5312) close pingcap#5313 ci: fix check-license github action (pingcap#5318) close pingcap#5317 update proxy to raftstore-proxy-6.2 (pingcap#5316) ref pingcap#4982 Change one `additional_input_at_end` to many streams in `ParallelInputsProcessor` (pingcap#5274) close pingcap#4856, close pingcap#5263 support fine grained shuffle for window function (pingcap#5048) close pingcap#5142 feat: pushdown get_format into TiFlash (pingcap#5269) close pingcap#5115 fix: format throw data truncated error (pingcap#5272) close pingcap#4891 Print content of columns for gtest (pingcap#5243) close pingcap#5203 *: also enable O3 for aarch64 (pingcap#5338) close pingcap#5342 Add debug image build target for CentOS7 (pingcap#5344) close pingcap#5343 *: mini refactor (pingcap#5326) close pingcap#4739 Refactor initialize of background pool (pingcap#5190) close pingcap#5189 delete copy/move ctor of MPMCQueue explicitly (pingcap#5328) close pingcap#5329 Introduce proxy_server and new-mock-engine-store (pingcap#5319) ref pingcap#5170 fix: incorrect uptime in grafana panel Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>

close pingcap#5240

SchrodingerZhu force-pushed the feat/arm-optimized-routines branch from 256a0f8 to 4a5b7cd Compare June 25, 2022 02:51

SchrodingerZhu added 15 commits June 28, 2022 10:07

feat: add optimized routines for aarch64

8a5b8d5

Signed-off-by: SchrodingerZhu <i@zhuyi.fan>

update

73da98f

Signed-off-by: SchrodingerZhu <i@zhuyi.fan>

fix

ec67996

Signed-off-by: SchrodingerZhu <i@zhuyi.fan>

fix

ac100ba

Signed-off-by: SchrodingerZhu <i@zhuyi.fan>

fix

ec8b008

Signed-off-by: SchrodingerZhu <i@zhuyi.fan>

fix format

15e92cd

Signed-off-by: SchrodingerZhu <i@zhuyi.fan>

use ifunc

ee5319d

Signed-off-by: SchrodingerZhu <i@zhuyi.fan>

fix

6ba4b28

Signed-off-by: SchrodingerZhu <i@zhuyi.fan>

fix

bd1c530

Signed-off-by: SchrodingerZhu <i@zhuyi.fan>

fix

c7db706

Signed-off-by: SchrodingerZhu <i@zhuyi.fan>

fix

431a46e

Signed-off-by: SchrodingerZhu <i@zhuyi.fan>

fix

2c86a5b

Signed-off-by: SchrodingerZhu <i@zhuyi.fan>

fix

61ec9c8

Signed-off-by: SchrodingerZhu <i@zhuyi.fan>

fix

113a182

Signed-off-by: SchrodingerZhu <i@zhuyi.fan>

doc: comments and considerations

4a0fd3e

Signed-off-by: SchrodingerZhu <i@zhuyi.fan>

SchrodingerZhu force-pushed the feat/arm-optimized-routines branch from 16eae43 to 4a0fd3e Compare June 28, 2022 02:08

ti-chi-bot removed the do-not-merge/needs-linked-issue label Jun 28, 2022

JinheLin approved these changes Jun 28, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 28, 2022

flowbehappy approved these changes Jun 29, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 29, 2022

JaySon-Huang reviewed Jun 29, 2022

View reviewed changes

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 29, 2022

Merge branch 'master' into feat/arm-optimized-routines

11d2fe4

Merge branch 'master' into feat/arm-optimized-routines

a713c1a

ti-chi-bot merged commit 1ff3b38 into pingcap:master Jun 29, 2022

Lloyd-Pottiger pushed a commit to Lloyd-Pottiger/tiflash that referenced this pull request Jul 19, 2022

feat: add optimized routines for aarch64 (pingcap#5231)

557c8fe

close pingcap#5240

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add optimized routines for aarch64 #5231

feat: add optimized routines for aarch64 #5231

SchrodingerZhu commented Jun 24, 2022 •

edited

Loading

ti-chi-bot commented Jun 24, 2022 •

edited

Loading

SchrodingerZhu commented Jun 25, 2022 •

edited

Loading

JaySon-Huang Jun 29, 2022

SchrodingerZhu Jun 29, 2022

SchrodingerZhu commented Jun 29, 2022

ti-chi-bot commented Jun 29, 2022

ti-chi-bot commented Jun 29, 2022

sre-bot commented Jun 29, 2022

sre-bot commented Jun 29, 2022

sre-bot commented Jun 29, 2022

feat: add optimized routines for aarch64 #5231

feat: add optimized routines for aarch64 #5231

Conversation

SchrodingerZhu commented Jun 24, 2022 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Jun 24, 2022 • edited Loading

SchrodingerZhu commented Jun 25, 2022 • edited Loading

JaySon-Huang Jun 29, 2022

Choose a reason for hiding this comment

SchrodingerZhu Jun 29, 2022

Choose a reason for hiding this comment

SchrodingerZhu commented Jun 29, 2022

ti-chi-bot commented Jun 29, 2022

ti-chi-bot commented Jun 29, 2022

sre-bot commented Jun 29, 2022

Coverage for changed files

Coverage summary

sre-bot commented Jun 29, 2022

Coverage for changed files

Coverage summary

sre-bot commented Jun 29, 2022

Coverage for changed files

Coverage summary

SchrodingerZhu commented Jun 24, 2022 •

edited

Loading

ti-chi-bot commented Jun 24, 2022 •

edited

Loading

SchrodingerZhu commented Jun 25, 2022 •

edited

Loading