Enhance executor join tests #5305

Willendless · 2022-07-06T21:07:51Z

What problem does this PR solve?

Issue Number: close #5198

Problem Summary:

What is changed and how it works?

Extract join related tests to a separate file.

Add more tests for join executor.

simpleJoinTests: test single join kind
multiJoinTests: test combination of multiple join kinds
castJoin: test join on boundary value equality
- currently, tiflash doesn't support type bit
~~subqueryJoin: test subquery join~~
- ~~[ ] todo: is it possible to write corelated subquery in current test framework?~~ (Currently apply operator can not be pushed down to tiflash)
join with aggregation

note: our current test framework only supports left, right and inner join.

Added expression support:

count
min

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

None

ti-chi-bot · 2022-07-06T21:07:53Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

SeaRise
ywqzzy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

SeaRise · 2022-07-11T09:37:16Z

/run-unit-test

sre-bot · 2022-07-11T09:56:41Z

Coverage for changed files

Filename                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/tests/gtest_executor.cpp               60                25    58.33%           2                 0   100.00%          32                 0   100.00%          16                 9    43.75%
Flash/tests/gtest_join_executor.cpp         383               269    29.77%          18                 0   100.00%         315                 0   100.00%          64                59     7.81%
TestUtils/mockExecutor.h                      6                 1    83.33%           6                 1    83.33%          15                 3    80.00%           0                 0         -
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                       449               295    34.30%          26                 1    96.15%         362                 3    99.17%          80                68    15.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18524      9404             49.23%    208920  94923        54.56%

full coverage report (for internal network access only)

dbms/src/TestUtils/mockExecutor.h

Willendless · 2022-07-12T03:33:44Z

/rebuild

Willendless · 2022-07-12T16:00:48Z

/rebuild

Willendless · 2022-07-12T16:00:55Z

/run-all-tests

sre-bot · 2022-07-12T16:19:15Z

Coverage for changed files

Filename                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/tests/gtest_executor.cpp               60                25    58.33%           2                 0   100.00%          32                 0   100.00%          16                 9    43.75%
Flash/tests/gtest_join_executor.cpp         383               269    29.77%          18                 0   100.00%         315                 0   100.00%          64                59     7.81%
TestUtils/mockExecutor.h                      6                 1    83.33%           6                 1    83.33%          15                 3    80.00%           0                 0         -
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                       449               295    34.30%          26                 1    96.15%         362                 3    99.17%          80                68    15.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18524      9397             49.27%    208920  94924        54.56%

full coverage report (for internal network access only)

Willendless · 2022-07-12T17:34:44Z

/run-integration-test

xzhangxian1008 · 2022-07-13T01:37:26Z

Looks good

Willendless · 2022-07-14T22:08:07Z

/run-all-tests

sre-bot · 2022-07-14T22:24:32Z

Coverage for changed files

Filename                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/tests/gtest_executor.cpp               60                25    58.33%           2                 0   100.00%          32                 0   100.00%          16                 9    43.75%
Flash/tests/gtest_join_executor.cpp         383               269    29.77%          18                 0   100.00%         315                 0   100.00%          64                59     7.81%
TestUtils/mockExecutor.h                      6                 1    83.33%           6                 1    83.33%          15                 3    80.00%           0                 0         -
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                       449               295    34.30%          26                 1    96.15%         362                 3    99.17%          80                68    15.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18524      9397             49.27%    208920  94883        54.58%

full coverage report (for internal network access only)

Willendless · 2022-07-14T23:43:42Z

/run-all-tests

sre-bot · 2022-07-14T23:54:24Z

Coverage for changed files

Filename                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/tests/gtest_executor.cpp               60                25    58.33%           2                 0   100.00%          32                 0   100.00%          16                 9    43.75%
Flash/tests/gtest_join_executor.cpp         383               269    29.77%          18                 0   100.00%         315                 0   100.00%          64                59     7.81%
TestUtils/mockExecutor.h                      6                 1    83.33%           6                 1    83.33%          15                 3    80.00%           0                 0         -
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                       449               295    34.30%          26                 1    96.15%         362                 3    99.17%          80                68    15.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18524      9397             49.27%    208920  94917        54.57%

full coverage report (for internal network access only)

Willendless · 2022-07-15T01:46:52Z

/run-all-tests

Willendless · 2022-07-15T01:50:11Z

/rebuild

sre-bot · 2022-07-15T01:58:19Z

Coverage for changed files

Filename                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/tests/gtest_executor.cpp               60                25    58.33%           2                 0   100.00%          32                 0   100.00%          16                 9    43.75%
Flash/tests/gtest_join_executor.cpp         383               269    29.77%          18                 0   100.00%         315                 0   100.00%          64                59     7.81%
TestUtils/mockExecutor.h                      6                 1    83.33%           6                 1    83.33%          15                 3    80.00%           0                 0         -
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                       449               295    34.30%          26                 1    96.15%         362                 3    99.17%          80                68    15.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18524      9397             49.27%    208920  94885        54.58%

full coverage report (for internal network access only)

ywqzzy

LGTM

Willendless · 2022-07-18T01:12:33Z

/run-all-tests

sre-bot · 2022-07-18T01:28:46Z

Coverage for changed files

Filename                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/tests/gtest_executor.cpp               60                25    58.33%           2                 0   100.00%          32                 0   100.00%          16                 9    43.75%
Flash/tests/gtest_join_executor.cpp         383               269    29.77%          18                 0   100.00%         315                 0   100.00%          64                59     7.81%
TestUtils/mockExecutor.h                      6                 1    83.33%           6                 1    83.33%          15                 3    80.00%           0                 0         -
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                       449               295    34.30%          26                 1    96.15%         362                 3    99.17%          80                68    15.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18611      9408             49.45%    211983  94949        55.21%

full coverage report (for internal network access only)

zanmato1984 · 2022-07-18T14:41:00Z

/merge

ti-chi-bot · 2022-07-18T14:41:01Z

@zanmato1984: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-07-18T14:41:04Z

This pull request has been accepted and is ready to merge.

Commit hash: ce971be

sre-bot · 2022-07-18T15:04:47Z

Coverage for changed files

Filename                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/tests/gtest_executor.cpp               60                25    58.33%           2                 0   100.00%          32                 0   100.00%          16                 9    43.75%
Flash/tests/gtest_join_executor.cpp         383               269    29.77%          18                 0   100.00%         315                 0   100.00%          64                59     7.81%
TestUtils/mockExecutor.h                      6                 1    83.33%           6                 1    83.33%          15                 3    80.00%           0                 0         -
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                       449               295    34.30%          26                 1    96.15%         362                 3    99.17%          80                68    15.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18617      9406             49.48%    212150  95004        55.22%

full coverage report (for internal network access only)

feat: add basic join tests

a4d2ca8

ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 6, 2022

chore: extract join related tests from gtest_executor.cpp file

3fd336c

ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 6, 2022

ywqzzy self-requested a review July 7, 2022 02:15

Willendless added 2 commits July 8, 2022 19:09

feat: add cast test

16eb687

feat: add joinAgg tests

8f90d8d

ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 10, 2022

Willendless added 2 commits July 10, 2022 17:42

format

b4230dd

chore: use ASSERT_COLUMNS_EQ_UR to do concurrency test

4bf22d2

Willendless changed the title ~~[WIP] enhance executor join tests~~ Enhance executor join tests Jul 10, 2022

ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 10, 2022

ywqzzy requested a review from xzhangxian1008 July 11, 2022 03:34

Merge branch 'master' into enhance-join-tests

87da827

ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 11, 2022

ywqzzy reviewed Jul 12, 2022

View reviewed changes

dbms/src/TestUtils/mockExecutor.h Outdated Show resolved Hide resolved

chore: fix min expr

9ec9a17

SeaRise self-requested a review July 13, 2022 08:37

Willendless changed the title ~~Enhance executor join tests~~ [DNM] Enhance executor join tests Jul 14, 2022

Willendless changed the title ~~[DNM] Enhance executor join tests~~ [WIP] Enhance executor join tests Jul 14, 2022

ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 14, 2022

Willendless added 4 commits July 14, 2022 17:25

chore: update in-class const variable decl with static

ceea922

chore: enhance simple tests with full/partial null case

9658165

chore: format

2881259

chore: allow max_concurrency_level

f09309e

Willendless changed the title ~~[WIP] Enhance executor join tests~~ Enhance executor join tests Jul 14, 2022

ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 14, 2022

ywqzzy approved these changes Jul 15, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 15, 2022

Merge branch 'pingcap:master' into enhance-join-tests

ce971be

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 18, 2022

Merge branch 'master' into enhance-join-tests

52e1eac

ti-chi-bot merged commit 5d680c4 into pingcap:master Jul 18, 2022

ywqzzy mentioned this pull request Jul 26, 2022

Interpreter & Executor & MPP unit test framework #4609

Closed

54 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enhance executor join tests #5305

Enhance executor join tests #5305

Willendless commented Jul 6, 2022 •

edited

Loading

ti-chi-bot commented Jul 6, 2022 •

edited

Loading

SeaRise commented Jul 11, 2022

sre-bot commented Jul 11, 2022

Willendless commented Jul 12, 2022

Willendless commented Jul 12, 2022

Willendless commented Jul 12, 2022

sre-bot commented Jul 12, 2022

Willendless commented Jul 12, 2022

xzhangxian1008 commented Jul 13, 2022

Willendless commented Jul 14, 2022

sre-bot commented Jul 14, 2022

Willendless commented Jul 14, 2022

sre-bot commented Jul 14, 2022

Willendless commented Jul 15, 2022

Willendless commented Jul 15, 2022

sre-bot commented Jul 15, 2022

ywqzzy left a comment

Willendless commented Jul 18, 2022

sre-bot commented Jul 18, 2022

zanmato1984 commented Jul 18, 2022

ti-chi-bot commented Jul 18, 2022

ti-chi-bot commented Jul 18, 2022

sre-bot commented Jul 18, 2022

Enhance executor join tests #5305

Enhance executor join tests #5305

Conversation

Willendless commented Jul 6, 2022 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Jul 6, 2022 • edited Loading

SeaRise commented Jul 11, 2022

sre-bot commented Jul 11, 2022

Coverage for changed files

Coverage summary

Willendless commented Jul 12, 2022

Willendless commented Jul 12, 2022

Willendless commented Jul 12, 2022

sre-bot commented Jul 12, 2022

Coverage for changed files

Coverage summary

Willendless commented Jul 12, 2022

xzhangxian1008 commented Jul 13, 2022

Willendless commented Jul 14, 2022

sre-bot commented Jul 14, 2022

Coverage for changed files

Coverage summary

Willendless commented Jul 14, 2022

sre-bot commented Jul 14, 2022

Coverage for changed files

Coverage summary

Willendless commented Jul 15, 2022

Willendless commented Jul 15, 2022

sre-bot commented Jul 15, 2022

Coverage for changed files

Coverage summary

ywqzzy left a comment

Choose a reason for hiding this comment

Willendless commented Jul 18, 2022

sre-bot commented Jul 18, 2022

Coverage for changed files

Coverage summary

zanmato1984 commented Jul 18, 2022

ti-chi-bot commented Jul 18, 2022

ti-chi-bot commented Jul 18, 2022

sre-bot commented Jul 18, 2022

Coverage for changed files

Coverage summary

Willendless commented Jul 6, 2022 •

edited

Loading

ti-chi-bot commented Jul 6, 2022 •

edited

Loading