Wrap & Optimize rest bin collator

[solotzg]

What problem does this PR solve?

Issue Number: ref #5294

What is changed and how it works?

• optimize rest bin collator

    enum class CollatorType : uint32_t
    {
        // bin
        UTF8MB4_BIN = 0,
        UTF8_BIN,
        LATIN1_BIN,
        ASCII_BIN,
        // binary
        BINARY,
        // ----
        UTF8_GENERAL_CI,
        UTF8MB4_GENERAL_CI,
        UTF8_UNICODE_CI,
        UTF8MB4_UNICODE_CI,
        // ----
        MAX_,
    };

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• guo-shaoge
• windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[solotzg]

/run-all-tests

[sre-bot]

Coverage for changed files

Filename                                       Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Columns/ColumnString.cpp                           172                88    48.84%          26                14    46.15%         402               224    44.28%         118                68    42.37%
Functions/CollationOperatorOptimized.h              40                17    57.50%           8                 2    75.00%         155                77    50.32%          28                10    64.29%
Functions/CollationStringSearchOptimized.h         141                 3    97.87%          20                 0   100.00%         302                 5    98.34%          84                 2    97.62%
Functions/FunctionsComparison.h                    604               308    49.01%          63                29    53.97%         949               513    45.94%         476               299    37.18%
Storages/Transaction/Collator.cpp                  223                40    82.06%          39                 5    87.18%         436                82    81.19%         156                59    62.18%
Storages/Transaction/Collator.h                      5                 1    80.00%           5                 1    80.00%           5                 1    80.00%           0                 0         -
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                             1185               457    61.43%         161                51    68.32%        2249               902    59.89%         862               438    49.19%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18953      9442             50.18%    214368  95431        55.48%

full coverage report (for internal network access only)

[windtalker]

Others LGTM

[solotzg]

/merge

[ti-chi-bot]

@solotzg: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: ced64b9

[sre-bot]

Coverage for changed files

Filename                                       Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Columns/ColumnString.cpp                           172                77    55.23%          26                12    53.85%         402               191    52.49%         118                59    50.00%
Functions/CollationOperatorOptimized.h              40                11    72.50%           8                 1    87.50%         155                49    68.39%          28                10    64.29%
Functions/CollationStringSearchOptimized.h         141                 3    97.87%          20                 0   100.00%         302                 5    98.34%          84                 2    97.62%
Functions/FunctionsComparison.h                    604               307    49.17%          63                29    53.97%         949               512    46.05%         476               287    39.71%
Storages/Transaction/Collator.cpp                  223                40    82.06%          39                 5    87.18%         436                82    81.19%         156                59    62.18%
Storages/Transaction/Collator.h                      5                 1    80.00%           5                 1    80.00%           5                 1    80.00%           0                 0         -
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                             1185               439    62.95%         161                48    70.19%        2249               840    62.65%         862               417    51.62%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
19255      9242             52.00%    218943  94023        57.06%

full coverage report (for internal network access only)