-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize mem utils functions #5658
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
- add `avx2_strstr` to accelerate substr search - add `avx2_mem_equal` to accelerate mem equal cmp
f4d60f7
to
0ce3688
Compare
ecc60e0
to
32d89f4
Compare
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/hold |
/merge |
@solotzg: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 8c85675
|
/merge |
@solotzg: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/unhold |
Coverage for changed files
Coverage summary
full coverage report (for internal network access only) |
/run-sanitizer-test asan |
This reverts commit a8c8cb1.
What problem does this PR solve?
Issue Number: ref #5294
What is changed and how it works?
avx2_strstr
,avx2_mem_equal
,avx2_memchr
avx2_strstr
is same asstd::string_view::find
avx2_mem_equal
is same asbcmp
orstd::memcmp(p1,p2,n) == 0
avx2_memchr
is same asstd::memchr
tiflash/libs/libcommon/include/common/StringRef.h
Line 93 in eaf1a4c
1000000
, instructions about avx512 may begin to get better resultslike
Benchmark
ENV
tiflash/dbms/src/Functions/tests/bench_collation.cpp
Lines 129 to 147 in eef9e22
bcmp
, mem_utils::memoryEqual(use avx512) andavx2_mem_equal
std::string_view::find
andavx2_strstr
MemUtilsEqual_xxx
means test str-size isxxx
MemUtilsStrStr_xxx_yyy
means testsrc-str-size
isxxx
andneedle-str-size
isyyy
SQL
Check List
Tests
Side effects
Documentation
Release note