PageStorage: Fine grained lock on external callbacks (#5699)

[ti-chi-bot]

This is an automated cherry-pick of #5699

What problem does this PR solve?

Issue Number: close #5697

Problem Summary:
The GC total time in logging does not include the time costs in clean_external_page.

In PageStorageImpl::gcImpl clean_external_page, we hold the callbacks_mutex until all external page gc done.

tiflash/dbms/src/Storages/Page/V3/PageStorageImpl.cpp

Lines 287 to 298 in 7acf7f5

	auto clean_external_page = [this]() {
	std::scoped_lock lock{callbacks_mutex};
	if (!callbacks_container.empty())
	{
	for (const auto & [ns_id, callbacks] : callbacks_container)
	{
	auto pending_external_pages = callbacks.scanner();
	auto alive_external_ids = getAliveExternalPageIds(ns_id);
	callbacks.remover(pending_external_pages, alive_external_ids);
	}
	}
	};

while the time cost in clean_external_page is not ignorable and may block new StorageDeltaMerge from being created

tiflash/dbms/src/Storages/Page/V3/PageStorageImpl.cpp

Lines 400 to 408 in 7acf7f5

	void PageStorageImpl::registerExternalPagesCallbacks(const ExternalPageCallbacks & callbacks)
	{
	std::scoped_lock lock{callbacks_mutex};
	assert(callbacks.scanner != nullptr);
	assert(callbacks.remover != nullptr);
	assert(callbacks.ns_id != MAX_NAMESPACE_ID);
	assert(callbacks_container.count(callbacks.ns_id) == 0);
	callbacks_container.emplace(callbacks.ns_id, callbacks);
	}

tiflash/dbms/src/Storages/DeltaMerge/DeltaMergeStore.cpp

Lines 342 to 343 in 7acf7f5

	// remember to unregister it when shutdown
	storage_pool->dataRegisterExternalPagesCallbacks(callbacks);

What is changed and how it works?

• Make the external pages cleaning callbacks safe even after table is dropped
• Use shared_ptr to refine the lock granularity of running external cleaning callbacks, so that creating table won't be block by the whole processing time of cleanExternalPage.
• Remove the non-atomic renaming table logic

Problem not yet resolve in this PR

• PageStorage gc may take long time in removing external pages from all tables #5700

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Fix the bug that page GC may block creating tables

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[ti-chi-bot]

@ti-chi-bot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.