Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add more tests for lead/lag #5792

Merged
merged 3 commits into from
Sep 7, 2022
Merged

add more tests for lead/lag #5792

merged 3 commits into from
Sep 7, 2022

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Sep 5, 2022

What problem does this PR solve?

Issue Number: ref #5579

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 5, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • windtalker
  • ywqzzy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 5, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Sep 5, 2022

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 5, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Sep 5, 2022

/hold cancel

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 5, 2022
SeaRise
SeaRise commented Sep 5, 2022
View reviewed changes
tests/fullstack-test/expr/lead_lag.test
Comment on lines +265 to +277
mysql> set @@tidb_isolation_read_engines='tiflash'; set tidb_enforce_mpp=1; select 'a', orde, part, value_str, lead(value_str, 18446744073709551615) over w from test.test_str window w as(PARTITION BY part ORDER BY orde) order by orde;
+---+------+------+-----------+----------------------------------------------+
| a | orde | part | value_str | lead(value_str, 18446744073709551615) over w |
+---+------+------+-----------+----------------------------------------------+
| a | 1 | 1 | 1 | NULL |
| a | 2 | 1 | | 1 |
| a | 3 | 1 | 3 | |
| a | 4 | 1 | 4 | 3 |
| a | 5 | 2 | 5 | NULL |
| a | 6 | 2 | NULL | 5 |
| a | 7 | 2 | 7 | NULL |
| a | 8 | 2 | 8 | 7 |
+---+------+------+-----------+----------------------------------------------+
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is UInt64 overflow, but tidb and tiflash behave the same :)
And the max value of mysql8.0 is 9223372036854775807.

@SeaRise
Copy link
Contributor Author

SeaRise commented Sep 5, 2022

/run-integration-test

@SeaRise SeaRise requested a review from ywqzzy September 7, 2022 02:25
ywqzzy
ywqzzy approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@ywqzzy ywqzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 7, 2022
windtalker
windtalker approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 7, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Sep 7, 2022

/merge

@ti-chi-bot
Copy link
Member

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: fc1d71c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 7, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Sep 7, 2022

/run-unit-test

@sre-bot
Copy link
Collaborator

sre-bot commented Sep 7, 2022

Coverage for changed files

no c/c++ source change detected

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18666      8197             56.09%    215949  84402        60.92%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 51d54e1 into pingcap:master Sep 7, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Sep 7, 2022

Coverage for changed files

no c/c++ source change detected

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18645      8332             55.31%    215664  85908        60.17%

full coverage report (for internal network access only)

@SeaRise SeaRise deleted the more_lead_lag_test branch September 7, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

@ywqzzy ywqzzy ywqzzy approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SeaRise @ti-chi-bot @sre-bot @windtalker @ywqzzy