Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLASH-1066] Fix bug for accessing invalid address of PODArray after its padding (#591) #592

Merged
merged 1 commit into from
Mar 31, 2020

Conversation

JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Mar 31, 2020

We have ported PODArray padding, but left its bugfix behind.

Without this fix, process will coredump if there are long string column (tpch.partsupp for example


cherry-pick of #591

Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang JaySon-Huang changed the title [FLASH-1066] Fix bug for accessing invalid address PODArray after its padding (#591) [FLASH-1066] Fix bug for accessing invalid address of PODArray after its padding (#591) Mar 31, 2020
@JaySon-Huang
Copy link
Contributor Author

/run-all-tests

Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JaySon-Huang JaySon-Huang merged commit 73c9aaf into pingcap:release-3.1 Mar 31, 2020
@JaySon-Huang JaySon-Huang deleted the FLASH-1066-to-3.1 branch March 31, 2020 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants