-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize count const not null #6187
Optimize count const not null #6187
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
RUNTIME_CHECK( | ||
schema[i].type->equals(*storage_schema[i].type), | ||
schema[i].name, | ||
schema[i].type->getName(), | ||
storage_schema[i].name, | ||
storage_schema[i].type->getName()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the storage_schema
is generated by storage_interpreter
, and storage_interpreter
is constructed by tidb_table_scan
. But the tidb_table_scan
come from tidb, which do not support delmark_column
, so we can not revise tidb_table_scan
, remove the check.
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
f68b3d1
to
d1fd2a6
Compare
/run-all-tests |
@Lloyd-Pottiger: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What problem does this PR solve?
Issue Number: close #5793, close #5613
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note