Json unquote extract pushdown #6377

yibin87 · 2022-11-28T12:29:16Z

What problem does this PR solve?

Issue Number: close #6376

Problem Summary:

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Signed-off-by: yibin <huyibin@pingcap.com>

ti-chi-bot · 2022-11-28T12:29:18Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

mengxin9014
solotzg

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot · 2022-11-28T12:29:18Z

@yibin87: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: yibin <huyibin@pingcap.com>

yibin87 · 2022-11-29T05:19:56Z

/run-all-tests

Signed-off-by: yibin <huyibin@pingcap.com>

yibin87 · 2022-11-29T06:50:46Z

/run-all-tests

dbms/src/Functions/FunctionsJson.cpp

dbms/src/Functions/FunctionsJson.h

dbms/src/Functions/tests/gtest_cast_json_as_string.cpp

dbms/src/Functions/tests/gtest_json_extract.cpp

dbms/src/Functions/tests/gtest_json_unquote.cpp

dbms/src/Storages/Transaction/DatumCodec.cpp

Signed-off-by: yibin <huyibin@pingcap.com>

yibin87 · 2022-12-01T01:25:42Z

/run-all-tests

mengxin9014

Others LGTM

dbms/src/Flash/Coprocessor/TiDBTime.h

solotzg · 2022-12-02T02:31:26Z

dbms/src/Common/UTF8Helpers.h

+static const UInt32 UNICODEMax = 0x0010FFFF; // Maximum valid Unicode code point.
+static const UInt32 UTF8Error = UNICODEMax + 1; // the "error" code


UNICODEMax -> UNICODE_MAX
UTF8Error -> UTF8_ERROR

Nice, changed it.

still UNICODE_Max

Yeah, I didn't notice the upper case, update it now.

dbms/src/Common/tests/gtest_UTF8Helpers.cpp

Signed-off-by: yibin <huyibin@pingcap.com>

dbms/src/IO/Endian.h

solotzg · 2022-12-02T03:12:04Z

Is there any code coverage report about your modification ?

yibin87 · 2022-12-02T03:14:33Z

/run-unit-test

yibin87 · 2022-12-02T03:15:13Z

Is there any code coverage report about your modification ?

I'll run tests to see.

yibin87 · 2022-12-02T03:15:41Z

/run-all-tests

yibin87 · 2022-12-02T03:40:54Z

/merge

ti-chi-bot · 2022-12-02T03:40:55Z

@yibin87: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-12-02T03:40:56Z

This pull request has been accepted and is ready to merge.

Commit hash: f18245a

yibin87 · 2022-12-02T04:05:09Z

/re-build

yibin87 · 2022-12-02T04:05:50Z

/re-builds

yibin87 · 2022-12-02T04:06:32Z

/rebuild

wuhuizuo · 2022-12-02T04:33:23Z

/run-unit-test
/run-integration-test

yibin87 added 11 commits November 9, 2022 09:45

Move tidb new json definitions to tiflash

5a922ce

Signed-off-by: yibin <huyibin@pingcap.com>

Little change

6ff6618

Signed-off-by: yibin <huyibin@pingcap.com>

Temporary changes

105a024

Signed-off-by: yibin <huyibin@pingcap.com>

Milestore 1

80dde7c

Signed-off-by: yibin <huyibin@pingcap.com>

Basic functionality milestone

2d6948b

Signed-off-by: yibin <huyibin@pingcap.com>

Save changes

f3fa2ed

Signed-off-by: yibin <huyibin@pingcap.com>

Save works

7176f6c

Signed-off-by: yibin <huyibin@pingcap.com>

Add integration tests

3dabf46

Signed-off-by: yibin <huyibin@pingcap.com>

Fix incorrect path expr handling logic

a80a9a7

Signed-off-by: yibin <huyibin@pingcap.com>

Little refact

dc78571

Signed-off-by: yibin <huyibin@pingcap.com>

Reuse memory buffer

b0089eb

Signed-off-by: yibin <huyibin@pingcap.com>

ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 28, 2022

yibin87 requested review from SeaRise and windtalker November 28, 2022 12:29

yibin87 added 2 commits November 29, 2022 09:03

Format changes

6fb24c9

Signed-off-by: yibin <huyibin@pingcap.com>

Merge branch 'master' into json_unquote_extract_pushdown

c6bc23e

yibin87 requested a review from mengxin9014 November 29, 2022 02:45

yibin87 added 2 commits November 29, 2022 10:58

Fix static analyze failure

2b39859

Signed-off-by: yibin <huyibin@pingcap.com>

Fix static analyze errors

62c1f8c

Signed-off-by: yibin <huyibin@pingcap.com>

yibin87 removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Nov 29, 2022

Fix tidy static analyze issues

a84125e

Signed-off-by: yibin <huyibin@pingcap.com>

Fix code change issue

1f11fde

Signed-off-by: yibin <huyibin@pingcap.com>

mengxin9014 reviewed Nov 29, 2022

View reviewed changes

Remove useless header

9e13d8c

Signed-off-by: yibin <huyibin@pingcap.com>

yibin87 requested a review from mengxin9014 November 29, 2022 08:37

mengxin9014 reviewed Dec 1, 2022

View reviewed changes

dbms/src/Flash/Coprocessor/TiDBTime.h Show resolved Hide resolved

yibin87 requested a review from mengxin9014 December 1, 2022 03:42

solotzg reviewed Dec 2, 2022

View reviewed changes

dbms/src/Common/tests/gtest_UTF8Helpers.cpp Show resolved Hide resolved

Update to comments

f18245a

Signed-off-by: yibin <huyibin@pingcap.com>

solotzg reviewed Dec 2, 2022

View reviewed changes

dbms/src/IO/Endian.h Show resolved Hide resolved

dbms/src/IO/Endian.h Show resolved Hide resolved

solotzg approved these changes Dec 2, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 2, 2022

mengxin9014 approved these changes Dec 2, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 2, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 2, 2022

ti-chi-bot added 2 commits December 2, 2022 11:41

Merge branch 'master' into json_unquote_extract_pushdown

a97df87

Merge branch 'master' into json_unquote_extract_pushdown

7210448

Merge branch 'master' into json_unquote_extract_pushdown

bdeba67

yibin87 merged commit 4bae244 into pingcap:master Dec 2, 2022

yibin87 mentioned this pull request Dec 2, 2022

json_extract using '0' report error #6388

Closed

yibin87 mentioned this pull request Nov 8, 2023

Support json_unquote function #8334

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Json unquote extract pushdown #6377

Json unquote extract pushdown #6377

yibin87 commented Nov 28, 2022 •

edited

Loading

ti-chi-bot commented Nov 28, 2022 •

edited

Loading

ti-chi-bot commented Nov 28, 2022

yibin87 commented Nov 29, 2022

yibin87 commented Nov 29, 2022

yibin87 commented Dec 1, 2022

mengxin9014 left a comment

solotzg Dec 2, 2022

yibin87 Dec 2, 2022

solotzg Dec 2, 2022

yibin87 Dec 2, 2022

solotzg commented Dec 2, 2022

yibin87 commented Dec 2, 2022

yibin87 commented Dec 2, 2022

yibin87 commented Dec 2, 2022

yibin87 commented Dec 2, 2022

ti-chi-bot commented Dec 2, 2022

ti-chi-bot commented Dec 2, 2022

yibin87 commented Dec 2, 2022

yibin87 commented Dec 2, 2022

yibin87 commented Dec 2, 2022

wuhuizuo commented Dec 2, 2022

		static const UInt32 UNICODEMax = 0x0010FFFF; // Maximum valid Unicode code point.
		static const UInt32 UTF8Error = UNICODEMax + 1; // the "error" code

Json unquote extract pushdown #6377

Json unquote extract pushdown #6377

Conversation

yibin87 commented Nov 28, 2022 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Nov 28, 2022 • edited Loading

ti-chi-bot commented Nov 28, 2022

yibin87 commented Nov 29, 2022

yibin87 commented Nov 29, 2022

yibin87 commented Dec 1, 2022

mengxin9014 left a comment

Choose a reason for hiding this comment

solotzg Dec 2, 2022

Choose a reason for hiding this comment

yibin87 Dec 2, 2022

Choose a reason for hiding this comment

solotzg Dec 2, 2022

Choose a reason for hiding this comment

yibin87 Dec 2, 2022

Choose a reason for hiding this comment

solotzg commented Dec 2, 2022

yibin87 commented Dec 2, 2022

yibin87 commented Dec 2, 2022

yibin87 commented Dec 2, 2022

yibin87 commented Dec 2, 2022

ti-chi-bot commented Dec 2, 2022

ti-chi-bot commented Dec 2, 2022

yibin87 commented Dec 2, 2022

yibin87 commented Dec 2, 2022

yibin87 commented Dec 2, 2022

wuhuizuo commented Dec 2, 2022

yibin87 commented Nov 28, 2022 •

edited

Loading

ti-chi-bot commented Nov 28, 2022 •

edited

Loading