Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support storing all data in UniversalPageStorage #6717

Merged
merged 37 commits into from
Feb 15, 2023
Merged

support storing all data in UniversalPageStorage #6717

merged 37 commits into from
Feb 15, 2023

Conversation

lidezhu
Copy link
Contributor

@lidezhu lidezhu commented Feb 2, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #6728

Problem Summary: we need to support storing all data in one Uni PS instance.

What is changed and how it works?

  1. Introduce PageStorageRunMode::UNI_PS to indicate to store table data and kvstore data in Uni PS;
  2. Introduce WriteBatchWrapper as the general write interface for UniversalWriteBatch and WriteBatch;

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 2, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • flowbehappy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 2, 2023
@lidezhu lidezhu changed the title add UniversalPageStorage [WIP] add UniversalPageStorage Feb 2, 2023
@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 2, 2023
@lidezhu lidezhu changed the title [WIP] add UniversalPageStorage [WIP] support to store all data in UniversalPageStorage Feb 2, 2023
@lidezhu lidezhu changed the title [WIP] support to store all data in UniversalPageStorage [WIP] support storing all data in UniversalPageStorage Feb 7, 2023
@lidezhu lidezhu removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 7, 2023
@lidezhu
Copy link
Contributor Author

lidezhu commented Feb 8, 2023

/rebuild

@lidezhu
Copy link
Contributor Author

lidezhu commented Feb 8, 2023

/run-all-tests

@lidezhu
Copy link
Contributor Author

lidezhu commented Feb 8, 2023

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 14, 2023
@lidezhu
Copy link
Contributor Author

lidezhu commented Feb 14, 2023

/merge

@ti-chi-bot
Copy link
Member

@lidezhu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5e4cd29

@ti-chi-bot ti-chi-bot added status/can-merge Indicates a PR has been approved by a committer. and removed status/can-merge Indicates a PR has been approved by a committer. labels Feb 14, 2023
@lidezhu
Copy link
Contributor Author

lidezhu commented Feb 14, 2023

/merge

@ti-chi-bot
Copy link
Member

@lidezhu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6a81b9a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 14, 2023
@lidezhu
Copy link
Contributor Author

lidezhu commented Feb 14, 2023

/run-unit-test

@lidezhu
Copy link
Contributor Author

lidezhu commented Feb 14, 2023

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2023
@iosmanthus iosmanthus mentioned this pull request Feb 14, 2023
Merged
18 tasks
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Feb 14, 2023
@lidezhu
Copy link
Contributor Author

lidezhu commented Feb 14, 2023

/run-all-tests

@lidezhu
Copy link
Contributor Author

lidezhu commented Feb 14, 2023

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2023
@lidezhu
Copy link
Contributor Author

lidezhu commented Feb 14, 2023

/merge

@ti-chi-bot
Copy link
Member

@lidezhu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 012df3d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 14, 2023
@ti-chi-bot ti-chi-bot merged commit a5d6f86 into pingcap:master Feb 15, 2023
@lidezhu lidezhu deleted the store-data-in-uni-ps branch February 15, 2023 02:50
@lidezhu lidezhu mentioned this pull request Feb 17, 2023
Merged
12 tasks
@iosmanthus iosmanthus mentioned this pull request Mar 10, 2023
Closed
15 tasks
@JaySon-Huang JaySon-Huang mentioned this pull request Sep 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@flowbehappy flowbehappy flowbehappy approved these changes

@breezewish breezewish Awaiting requested review from breezewish

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lidezhu @ti-chi-bot @JaySon-Huang @flowbehappy