-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix an exception thrown while reading from ColumnFileTiny after add column #6729
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
/run-unit-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 734ebc0
|
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
…olumn (pingcap#6729) close pingcap#6726 Signed-off-by: ywqzzy <592838129@qq.com>
What problem does this PR solve?
Issue Number: close #6726
Testing workload
This might lead to an exception with error message
Reading with fields but entry size is 0
Problem Summary:
Because only the newly added column is read,
fields.length() == 0
. It violates an assumption in BlobStore::read and an exception is throwntiflash/dbms/src/Storages/DeltaMerge/ColumnFile/ColumnFileTiny.cpp
Lines 62 to 80 in 4206a52
tiflash/dbms/src/Storages/Page/V3/BlobStore.cpp
Lines 582 to 586 in 4206a52
What is changed and how it works?
ColumnFileTiny::readFromDisk
, skip reading from disk if all are filled by default columnBlobStore::read
return an PageMap with empty Page instead of throwing exceptionsCheck List
Tests
Side effects
Documentation
Release note