Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an exception thrown while reading from ColumnFileTiny after add column #6729

Merged
merged 7 commits into from
Feb 6, 2023

Conversation

JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Feb 3, 2023

What problem does this PR solve?

Issue Number: close #6726

Testing workload

  1. Run TPCC workload
  2. Add a column
  3. Only read the newly added column

This might lead to an exception with error message Reading with fields but entry size is 0

Problem Summary:

Because only the newly added column is read, fields.length() == 0. It violates an assumption in BlobStore::read and an exception is thrown

PageStorage::PageReadFields fields;
fields.first = data_page_id;
for (size_t index = col_start; index < col_end; ++index)
{
const auto & cd = column_defines[index];
if (auto it = colid_to_offset.find(cd.id); it != colid_to_offset.end())
{
auto col_index = it->second;
fields.second.push_back(col_index);
}
else
{
// New column after ddl is not exist in this pack, fill with default value
columns[index - col_start] = createColumnWithDefaultValue(cd, rows);
}
}
auto page_map = page_reader.read({fields});
Page page = page_map[data_page_id];

// Read with `FieldReadInfos`, buf_size must not be 0.
if (buf_size == 0)
{
throw Exception("Reading with fields but entry size is 0.", ErrorCodes::LOGICAL_ERROR);
}

What is changed and how it works?

  • In ColumnFileTiny::readFromDisk, skip reading from disk if all are filled by default column
  • In BlobStore::read return an PageMap with empty Page instead of throwing exceptions
  • Add some checks to ensure we will not save an empty block/empty column

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the issue that reading the newly added column after an `ADD COLUMN` DDL might cause error

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 3, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Lloyd-Pottiger
  • lidezhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 3, 2023
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. and removed do-not-merge/needs-triage-completed labels Feb 3, 2023
@JaySon-Huang JaySon-Huang changed the title [TEST] Add more check and logs Fix an exception thrown while reading from ColumnFileTiny after add column Feb 3, 2023
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Feb 3, 2023
@JaySon-Huang
Copy link
Contributor Author

/cc @lidezhu @hongyunyan @flowbehappy

@JaySon-Huang
Copy link
Contributor Author

/run-all-tests

@JaySon-Huang
Copy link
Contributor Author

/run-unit-test

Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 6, 2023
Copy link
Contributor

@lidezhu lidezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 6, 2023
@JaySon-Huang
Copy link
Contributor Author

/run-all-tests

Copy link
Contributor

@hongyunyan hongyunyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JaySon-Huang
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 734ebc0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 6, 2023
@ti-chi-bot ti-chi-bot merged commit 817b5d0 into pingcap:master Feb 6, 2023
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Feb 6, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #6738.

@JaySon-Huang JaySon-Huang deleted the read_empty_col_log branch February 6, 2023 07:22
ywqzzy pushed a commit to ywqzzy/tiflash_1 that referenced this pull request Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

htap ddl daily tests failed: DB::Exception: Reading with fields but entry size is 0
5 participants