Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Add stale read design doc #6867

Merged
merged 9 commits into from
Feb 23, 2023
Merged

doc: Add stale read design doc #6867

merged 9 commits into from
Feb 23, 2023

Conversation

hehechen
Copy link
Contributor

@hehechen hehechen commented Feb 21, 2023 •
edited by JaySon-Huang
Loading

What problem does this PR solve?

Issue Number: ref #4483

Problem Summary:
Add stale read design doc

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 21, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CalvinNeo
  • JaySon-Huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 21, 2023
@hehechen
add stale read doc
238830b 
Signed-off-by: hehechen <awd123456sss@gmail.com>
JaySon-Huang
JaySon-Huang approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

docs/design/2023-02-21-tiflash-supports-stale-read.md Outdated Show resolved Hide resolved
docs/design/2023-02-21-tiflash-supports-stale-read.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 22, 2023
hehechen and others added 6 commits February 22, 2023 22:55
@hehechen @CalvinNeo
Update docs/design/2023-02-21-tiflash-supports-stale-read.md
dccfd48 
Co-authored-by: Calvin Neo <CalvinNeo@users.noreply.github.com>
@hehechen @CalvinNeo
Update docs/design/2023-02-21-tiflash-supports-stale-read.md
ccb2a21 
Co-authored-by: Calvin Neo <CalvinNeo@users.noreply.github.com>
@hehechen @CalvinNeo
Update docs/design/2023-02-21-tiflash-supports-stale-read.md
50d2488 
Co-authored-by: Calvin Neo <CalvinNeo@users.noreply.github.com>
@hehechen @CalvinNeo
Update docs/design/2023-02-21-tiflash-supports-stale-read.md
7eaddfa 
Co-authored-by: Calvin Neo <CalvinNeo@users.noreply.github.com>
@hehechen @JaySon-Huang
Update docs/design/2023-02-21-tiflash-supports-stale-read.md
e2e4688 
Co-authored-by: JaySon <tshent@qq.com>
@hehechen @JaySon-Huang
Update docs/design/2023-02-21-tiflash-supports-stale-read.md
f2e9d16 
Co-authored-by: JaySon <tshent@qq.com>
@hehechen hehechen requested a review from CalvinNeo February 22, 2023 15:00
@JaySon-Huang JaySon-Huang changed the title Add stale read design doc doc: Add stale read design doc Feb 23, 2023
CalvinNeo
CalvinNeo approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 23, 2023
@hehechen
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@hehechen: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f2e9d16

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 23, 2023
@hehechen
Copy link
Contributor Author

/run-unit-test

@ti-chi-bot
Copy link
Member

@hehechen: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hehechen
Copy link
Contributor Author

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 4a4f5d8 into pingcap:master Feb 23, 2023
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Feb 23, 2023
@hehechen @JaySon-Huang
doc: Add stale read design doc (pingcap#6867)
5c82c92 
ref pingcap#4483
@hehechen hehechen deleted the staleread branch February 23, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalvinNeo CalvinNeo CalvinNeo approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@flowbehappy flowbehappy Awaiting requested review from flowbehappy

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hehechen @ti-chi-bot @JaySon-Huang @CalvinNeo