Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix exception when no tcp and http server created #7281

Merged
merged 5 commits into from
Apr 12, 2023

Conversation

ywqzzy
Copy link
Contributor

@ywqzzy ywqzzy commented Apr 12, 2023

What problem does this PR solve?

Issue Number: close #7282

Problem Summary:
When no tcp and http server created, tiflash might have exception.

What is changed and how it works?

Allow tiflash to have no tcp and http server, just print an warning log.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    As the issue said
➜  ~ tiup playground v7.1.0 --tiflash.config=~/tiflash.config
tiup is checking updates for component playground ...
A new version of playground is available:
   The latest version:         v1.16.0
   Local installed version:    v1.10.3
   Update current component:   tiup update playground
   Update all components:      tiup update --all

Starting component `playground`: /Users/bba/.tiup/components/playground/v1.10.3/tiup-playground v7.1.0 --tiflash.config=~/tiflash.config
Playground Bootstrapping...
Start pd instance:v7.1.0
Start tikv instance:v7.1.0
Start tidb instance:v7.1.0
Waiting for tidb instances ready
[127.0.0.1:4000](http://127.0.0.1:4000/) ... Done
Start tiflash instance:v7.1.0
Waiting for tiflash instances ready
Waiting for tiflash instances ready
[127.0.0.1:3930](http://127.0.0.1:3930/) ... Error
CLUSTER START SUCCESSFULLY, Enjoy it ^-^
To connect TiDB: mysql --comments --host [127.0.0.1](http://127.0.0.1/) --port 4000 -u root -p (no password)
To view the dashboard: http://127.0.0.1:2379/dashboard
PD client endpoints: [[127.0.0.1:2379](http://127.0.0.1:2379/)]
To view the Prometheus: http://127.0.0.1:9090/
To view the Grafana: http://127.0.0.1:3000/
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 12, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Lloyd-Pottiger
  • SeaRise

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Apr 12, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 12, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 12, 2023
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 12, 2023
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 12, 2023
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Apr 12, 2023

/merge

@ti-chi-bot
Copy link
Member

@ywqzzy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f485f35

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 12, 2023
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Apr 12, 2023

/run-all-tests

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Apr 12, 2023

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit d993276 into pingcap:master Apr 12, 2023
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 labels Jul 12, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #9221.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Jul 12, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Jul 12, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #9222.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.3: #9223.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Jul 12, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

when no tcp server and http server created, unexpected exception throw
5 participants