Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix query fail when there are timestamp or time columns after generated column #7469

Merged
merged 9 commits into from
May 16, 2023
Merged

Fix query fail when there are timestamp or time columns after generated column #7469

merged 9 commits into from
May 16, 2023

Conversation

Lloyd-Pottiger
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger commented May 12, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #7468, close #7455

Problem Summary:

What is changed and how it works?

  1. handle generated column before handling timezone/duration cast
  2. handle column type changed after duration type filter pushed down
  3. refine some code in StorageDisaggregated

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@Lloyd-Pottiger
fix
006ff42 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 12, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • SeaRise

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 12, 2023
@Lloyd-Pottiger
fix for pipeline
698f46c 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 12, 2023
@Lloyd-Pottiger
Copy link
Contributor Author

/run-all-tests

@Lloyd-Pottiger
Copy link
Contributor Author

/cc @SeaRise @guo-shaoge @ywqzzy

@Lloyd-Pottiger
fix 7455
ac7770b 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 15, 2023
@Lloyd-Pottiger
address comments
2dcf447 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@Lloyd-Pottiger
fix recordProfileStreams
68a9ffa 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@Lloyd-Pottiger
Copy link
Contributor Author

/cc @JaySon-Huang @SeaRise

@ti-chi-bot ti-chi-bot bot requested review from JaySon-Huang and SeaRise May 16, 2023 05:39
JaySon-Huang
JaySon-Huang approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 16, 2023
@Lloyd-Pottiger
fix recordProfileStreams of PushedDownFilter
50fe23e 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@SeaRise SeaRise self-requested a review May 16, 2023 08:02
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 16, 2023
@Lloyd-Pottiger
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 16, 2023

@Lloyd-Pottiger: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 16, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 6d48424

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 16, 2023
@SeaRise
Copy link
Contributor

SeaRise commented May 16, 2023

/run-unit-test

@Lloyd-Pottiger
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot bot merged commit 698fdde into pingcap:master May 16, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request May 16, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #7482.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request May 16, 2023
@Lloyd-Pottiger @ti-chi-bot
This is an automated cherry-pick of pingcap#7469
f6bd003 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request May 16, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #7483.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request May 16, 2023
@Lloyd-Pottiger @ti-chi-bot
This is an automated cherry-pick of pingcap#7469
61754ed 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@Lloyd-Pottiger Lloyd-Pottiger deleted the fix-timestamp-after-generated branch May 16, 2023 08:44
ti-chi-bot bot pushed a commit that referenced this pull request May 16, 2023
@ti-chi-bot
Fix query fail when there are timestamp or time columns after generat…
06e24ee 
…ed column (#7469) (#7483)

close #7455, close #7468
ti-chi-bot bot pushed a commit that referenced this pull request May 16, 2023
@ti-chi-bot
Fix query fail when there are timestamp or time columns after generat…
0b00195 
…ed column (#7469) (#7482)

close #7468
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeaRise SeaRise SeaRise approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@guo-shaoge guo-shaoge Awaiting requested review from guo-shaoge

@ywqzzy ywqzzy Awaiting requested review from ywqzzy

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
4 participants
@Lloyd-Pottiger @SeaRise @ti-chi-bot @JaySon-Huang