Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: refactor grouping function implementation #7583

Merged
merged 8 commits into from
Jun 5, 2023
Merged

expression: refactor grouping function implementation #7583

merged 8 commits into from
Jun 5, 2023

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Jun 1, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #7590

Problem Summary:
As described above, pingcap/tipb#308 tipb PR

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

expression: refactor grouping function implementation

@AilinKid
refactor grouping function implementation
26aa95a 
Signed-off-by: AilinKid <ailinsilence4@gmail.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 1, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • guo-shaoge
  • xzhangxian1008

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 1, 2023
xzhangxian1008
xzhangxian1008 reviewed Jun 2, 2023
View reviewed changes
dbms/src/Functions/tests/gtest_grouping.cpp Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to add more cases when we have multi parameters

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 2, 2023
xzhangxian1008
xzhangxian1008 approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 2, 2023
@AilinKid
make fmt
0f2631a 
Signed-off-by: AilinKid <ailinsilence4@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 2, 2023
@AilinKid
Copy link
Contributor Author

AilinKid commented Jun 2, 2023

/rebuild

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 2, 2023
@AilinKid
update tipb
8dfe134 
Signed-off-by: AilinKid <ailinsilence4@gmail.com>
@AilinKid
Copy link
Contributor Author

AilinKid commented Jun 2, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 2, 2023

@AilinKid: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 2, 2023

@AilinKid: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@solotzg
Copy link
Contributor

solotzg commented Jun 2, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 2, 2023

@solotzg: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 2, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 8dfe134

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 2, 2023
@AilinKid
Copy link
Contributor Author

AilinKid commented Jun 2, 2023

/retest

@AilinKid
Copy link
Contributor Author

AilinKid commented Jun 2, 2023

/run-unit-test

@AilinKid
Copy link
Contributor Author

AilinKid commented Jun 2, 2023

/run-tide

@AilinKid
Copy link
Contributor Author

AilinKid commented Jun 2, 2023

Issue Number: close #7590

@AilinKid
trigger tide check
4d40e43 
Signed-off-by: AilinKid <ailinsilence4@gmail.com>
@ti-chi-bot ti-chi-bot bot removed do-not-merge/needs-linked-issue status/can-merge Indicates a PR has been approved by a committer. labels Jun 2, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 2, 2023

Merge canceled because a new commit is pushed.

@windtalker
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 2, 2023

@windtalker: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@guo-shaoge
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 4, 2023

@guo-shaoge: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@guo-shaoge
Copy link
Contributor

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Jun 4, 2023
@guo-shaoge
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 4, 2023
windtalker
windtalker approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM

dbms/src/Functions/FunctionsGrouping.h Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 5, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guo-shaoge, windtalker, xzhangxian1008

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [guo-shaoge,windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 5, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 5, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-04 12:46:36.440771695 +0000 UTC m=+179582.713744479: ☑️ agreed by guo-shaoge.
  • 2023-06-05 01:30:16.491888142 +0000 UTC m=+225402.764860926: ☑️ agreed by windtalker.

@ti-chi-bot ti-chi-bot bot merged commit e3da460 into pingcap:master Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xzhangxian1008 xzhangxian1008 xzhangxian1008 approved these changes

@guo-shaoge guo-shaoge guo-shaoge approved these changes

@windtalker windtalker windtalker approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

grouping function should support multi args like grouping(a,b,c)...
5 participants
@AilinKid @solotzg @windtalker @guo-shaoge @xzhangxian1008