Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

function: fix grouping function result name #7718

Merged
merged 3 commits into from
Jun 29, 2023

Conversation

AilinKid
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #7717

Problem Summary:

What is changed and how it works?

Check List

Tests

create table t(a int, b int, c int);
alter table t set tiflash replica 1;
insert into t values(1,1),(1,2);
select count(1), grouping(a), grouping(b) from t group by a,b with rollup;
select count(1), grouping(b), grouping(a) from t group by a,b with rollup;
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

function: fix grouping function result name

Signed-off-by: AilinKid <ailinsilence4@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 28, 2023
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 29, 2023
Copy link
Contributor

@SeaRise SeaRise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SeaRise, xzhangxian1008

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 29, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 29, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-29 01:17:44.350627936 +0000 UTC m=+843229.751878369: ☑️ agreed by xzhangxian1008.
  • 2023-06-29 04:10:58.907207577 +0000 UTC m=+853624.308458025: ☑️ agreed by SeaRise.

@SeaRise
Copy link
Contributor

SeaRise commented Jun 29, 2023

/check-issue-triage-complete

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 29, 2023

@AilinKid: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@SeaRise
Copy link
Contributor

SeaRise commented Jun 29, 2023

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 29, 2023
@SeaRise
Copy link
Contributor

SeaRise commented Jun 29, 2023

@AilinKid
You can comment /hold cancel when you want to merge this pr

@AilinKid
Copy link
Contributor Author

/hold cancel

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 29, 2023
@SeaRise
Copy link
Contributor

SeaRise commented Jun 29, 2023

/run-all-tests

@ti-chi-bot ti-chi-bot bot merged commit 56d851d into pingcap:master Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

function: different grouping function will be resolved to a same one because expression action re-usage
3 participants