Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Enhance page-ctl #8092

Merged
merged 11 commits into from
Sep 18, 2023
Merged

*: Enhance page-ctl #8092

merged 11 commits into from
Sep 18, 2023

Conversation

JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Sep 13, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #4646

Problem Summary:

What is changed and how it works?

  • Add more information shown when using page-ctl
  • Move some tests to TiDB/tests after Refactor kvstore #8073
  • Rename RegionTable::tryWriteBlockByRegionAndFlush to RegionTable::tryWriteBlockByRegion
  • Remove useless codes of VirtualColumn

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 13, 2023
@JaySon-Huang JaySon-Huang marked this pull request as draft September 13, 2023 16:17
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 13, 2023
CalvinNeo
CalvinNeo approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 13, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 14, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, lidezhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 14, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 14, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-13 16:39:29.12987176 +0000 UTC m=+103535.097459811: ☑️ agreed by CalvinNeo.
  • 2023-09-14 07:52:55.344475801 +0000 UTC m=+158341.312063850: ☑️ agreed by lidezhu.

@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 18, 2023
@JaySon-Huang JaySon-Huang marked this pull request as ready for review September 18, 2023 10:52
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 18, 2023
@JaySon-Huang
Copy link
Contributor Author

/run-all-tests

@JaySon-Huang
Copy link
Contributor Author

/run-integration-test

@ti-chi-bot ti-chi-bot bot merged commit 537cccf into pingcap:master Sep 18, 2023
@JaySon-Huang JaySon-Huang deleted the remove_useless branch September 19, 2023 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidezhu lidezhu lidezhu approved these changes

@CalvinNeo CalvinNeo CalvinNeo approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JaySon-Huang @CalvinNeo @lidezhu