Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort raft snapshot related utils into different modules #8105

Merged
merged 4 commits into from
Sep 18, 2023

Conversation

CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Sep 15, 2023

What problem does this PR solve?

Issue Number: ref #7777 ref #4646

Problem Summary:

The pr is:

  1. as part of kvstore refactor
  2. as part of parallel pre-handling single snapshot
  3. remove some needless utils
  4. move some raft-related utils into these modules

We've done the following in this pr:

  1. an PrehandleSnapshot.cpp which is about how to generate column format files(DTFiles) from SST format(including a whole rocksdb instance) file
  2. an IngestSST.cpp which is about how to ingest an sst file as part of data of a region.
  3. an ApplySnapshot.cpp is about how to replace data in a certain key range.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 15, 2023
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
Copy link
Member Author

/run-all-tests

Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with small comments

dbms/src/Storages/KVStore/MultiRaft/ApplySnapshot.cpp Outdated Show resolved Hide resolved
dbms/src/Storages/KVStore/MultiRaft/PrehandleSnapshot.cpp Outdated Show resolved Hide resolved
dbms/src/Storages/KVStore/Region.cpp Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 18, 2023
CalvinNeo and others added 3 commits September 18, 2023 12:38
Co-authored-by: JaySon <tshent@qq.com>
@CalvinNeo
Copy link
Member Author

/run-all-tests

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, lidezhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,lidezhu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 18, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 18, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-18 03:51:21.231469445 +0000 UTC m=+489447.199057494: ☑️ agreed by JaySon-Huang.
  • 2023-09-18 04:58:27.813773171 +0000 UTC m=+493473.781361222: ☑️ agreed by lidezhu.

@ti-chi-bot ti-chi-bot bot merged commit b5776d5 into pingcap:master Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants