Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine log for cop/batch cop #8182

Merged
merged 4 commits into from
Oct 11, 2023
Merged

Conversation

windtalker
Copy link
Contributor

@windtalker windtalker commented Oct 11, 2023

What problem does this PR solve?

Issue Number: close #8181

Problem Summary:

What is changed and how it works?

  1. refine the log of cop/batch cop
  2. refine the log inside client-c for remote read
  3. update client-c to fix some minor bugs

Before this pr, the log for cop/batch cop is

[DEBUG] [PhysicalPlan.cpp:84] ["tidb table scan has runtime filter size:0"] [source=CoprocessorHandler(stream)] [thread_id=240]

The log for client-c remote read is

[INFO] [<unknown>] ["thread start."] [source=pingcap/coprocessor] [thread_id=250]

After this pr, these log will be

[DEBUG] [PhysicalPlan.cpp:84] ["tidb table scan has runtime filter size:0"] [source="Coprocessor, is_remote_read: true, start_ts: 444859118261370884, region_info: {1125035, 2, 1088}, resource_group: default"] [thread_id=283]
[INFO] [<unknown>] ["thread start."] [source="MPP<gather_id:<gather_id:1, query_ts:1697002862090574000, local_query_id:26, server_id:1412, start_ts:444859118274478084, resource_group: default>,task_id:1> pingcap/coprocessor"] [thread_id=287]

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 11, 2023
@SeaRise SeaRise self-requested a review October 11, 2023 05:50
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 11, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gengliqi, SeaRise

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 11, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 11, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-11 05:54:58.127014973 +0000 UTC m=+1204495.714125103: ☑️ agreed by SeaRise.
  • 2023-10-11 06:30:31.613603316 +0000 UTC m=+1206629.200713446: ☑️ agreed by gengliqi.

@windtalker
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 11, 2023

@windtalker: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 7e44baf into pingcap:master Oct 11, 2023
6 checks passed
@windtalker windtalker deleted the refine_log_of_cop branch October 11, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refine the log of cop/batchcop
3 participants