Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make part of the ci work for raftstore-v2 #8199

Merged
merged 21 commits into from
Oct 20, 2023
Merged

Make part of the ci work for raftstore-v2 #8199

merged 21 commits into from
Oct 20, 2023

Conversation

CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Oct 17, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #8089

Problem Summary:

We stablize the current support for raftstore-v2 into ci tests.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@CalvinNeo
f
2cd1134 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 17, 2023
@CalvinNeo
fix segment empty
c032c70 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 17, 2023
@CalvinNeo
add
2796f9b 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 17, 2023
@CalvinNeo
Copy link
Member Author

/run-all-tests

@CalvinNeo
a
55a85cc 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
Copy link
Member Author

/run-all-tests

@CalvinNeo
Copy link
Member Author

/run-integration-test

@CalvinNeo
fix
2075806 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 17, 2023
@CalvinNeo
Copy link
Member Author

/run-integration-test

@CalvinNeo
aaaaa
210db1b 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
Copy link
Member Author

/run-integration-test

@CalvinNeo
a
9428086 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
z
25c8e30 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 17, 2023
@CalvinNeo
Copy link
Member Author

/run-integration-test

1 similar comment
@CalvinNeo
Copy link
Member Author

/run-integration-test

@CalvinNeo
debug run.sh
62e0e72 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
fix ci
953d711 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
Copy link
Member Author

/run-integration-test

@CalvinNeo
aaa
287821c 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
Copy link
Member Author

/run-integration-test

@CalvinNeo
recover
9ad3ba3 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
Copy link
Member Author

/run-integration-test

@CalvinNeo
f
da0008c 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
Copy link
Member Author

/run-integration-test

@CalvinNeo
a
68a6b73 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
Copy link
Member Author

/run-integration-test

1 similar comment
@CalvinNeo
Copy link
Member Author

/run-integration-test

@CalvinNeo CalvinNeo changed the title dnm Make ci work for raftstore-v2 Make part of the ci work for raftstore-v2 Oct 19, 2023
Lloyd-Pottiger
Lloyd-Pottiger approved these changes Oct 19, 2023
View reviewed changes
tests/docker/config/tikv_v2.toml Outdated Show resolved Hide resolved
tests/fullstack-test2/run.sh Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 19, 2023
CalvinNeo and others added 2 commits October 19, 2023 16:42
@CalvinNeo @Lloyd-Pottiger
Update tests/fullstack-test2/run.sh
ebaab2e 
Co-authored-by: Lloyd-Pottiger <60744015+Lloyd-Pottiger@users.noreply.github.com>
@CalvinNeo
Merge branch 'master' into ease-v2-test
16083d3
@CalvinNeo
Copy link
Member Author

/run-all-tests

@CalvinNeo @Lloyd-Pottiger
Update tests/docker/config/tikv_v2.toml
6c7c36a 
Co-authored-by: Lloyd-Pottiger <60744015+Lloyd-Pottiger@users.noreply.github.com>
@CalvinNeo
Copy link
Member Author

/run-all-tests

@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 20, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JinheLin, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JinheLin,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 20, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 20, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-19 08:33:31.225834254 +0000 UTC m=+1905208.812944384: ☑️ agreed by Lloyd-Pottiger.
  • 2023-10-20 06:33:41.404759573 +0000 UTC m=+1984418.991869718: ☑️ agreed by JinheLin.

@CalvinNeo
Copy link
Member Author

/run-integration-test

@ti-chi-bot ti-chi-bot bot merged commit 3ee29ab into pingcap:master Oct 20, 2023
6 checks passed
JaySon-Huang
JaySon-Huang reviewed Oct 23, 2023
View reviewed changes
dbms/src/Storages/DeltaMerge/DeltaMergeStore_Ingest.cpp
updated_segments = ingestDTFilesUsingSplit(dm_context, range, external_files, files, clear_data_in_range);
else
updated_segments = ingestDTFilesUsingColumnFile(dm_context, range, files, clear_data_in_range);
if (!segments.empty() || !external_files.empty())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think here accessing segments without any lock protection will cause data race in corner cases @CalvinNeo

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix in #8245

@JaySon-Huang JaySon-Huang mentioned this pull request Oct 26, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang left review comments

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@JinheLin JinheLin JinheLin approved these changes

@hongyunyan hongyunyan Awaiting requested review from hongyunyan

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Dynamic Region] An empty snapshot may still create segment
4 participants
@CalvinNeo @JaySon-Huang @JinheLin @Lloyd-Pottiger