Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the compatibility issue in func FunctionIPv4NumToString (#8210) #8228

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8210

What problem does this PR solve?

Issue Number: close #8211
Problem Summary:

CREATE TABLE t0(c0 INT);
ALTER TABLE t0 SET TIFLASH REPLICA 1;
SELECT SLEEP(5);

SELECT /*+ READ_FROM_STORAGE(TIKV[t0])*/t0.c0 FROM t0 WHERE INET_NTOA(t0.c0);
SELECT /*+ READ_FROM_STORAGE(TIFLASH[t0])*/t0.c0 FROM t0 WHERE INET_NTOA(t0.c0); -- ERROR 1105 (HY000): other error for mpp stream: Code: 43, e.displayText() = DB::Exception: Illegal type Int32 of argument of function IPv4NumToString, expected UInt32, e.what() = DB::Exception,

FunctionIPv4NumToString only supports argument whose type is UInt32.

What is changed and how it works?

  • Make FunctionIPv4NumToString support unsigned integer data type.
  • MySQL will return NULL and warning if failed to cast into 4 bytes unsigned integer(include Out of range). Under MPP mode, TiFlash will omit warning.
    • Warning 1411: Incorrect integer value: '?.?.?' for function inet_ntoa

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the compatibility issue in expression `inet_ntoa()`

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Oct 20, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 20, 2023

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@solotzg
Copy link
Contributor

solotzg commented Oct 20, 2023

/approve

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 20, 2023

@solotzg: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

  • Currently the CI jobs are not prow job style, we need it to notify Jenkins server to run them.
  • If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: solotzg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 20, 2023
@solotzg
Copy link
Contributor

solotzg commented Oct 20, 2023

/cc @windtalker

@ti-chi-bot ti-chi-bot bot requested a review from windtalker October 20, 2023 03:56
Signed-off-by: Zhigao Tong <tongzhigao@pingcap.com>
@solotzg
Copy link
Contributor

solotzg commented Oct 20, 2023

/run-all-tests

@solotzg
Copy link
Contributor

solotzg commented Oct 20, 2023

/run-unit-test

@solotzg solotzg closed this Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants