Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check RU in read thread of Storage. #8369

Merged
merged 11 commits into from
Nov 17, 2023
Merged

Check RU in read thread of Storage. #8369

merged 11 commits into from
Nov 17, 2023

Conversation

JinheLin
Copy link
Contributor

@JinheLin JinheLin commented Nov 13, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #8362

What is changed and how it works?

  1. Check whether RU is exhausted in MergedTask. If RU is exhausted, yield this task.
  2. Check whether RU is exhausted is SegmentReadTaskScheduler. If RU is exhausted, don't schedule this SegmentReadTaskPool.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 13, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 14, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 17, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 17, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guo-shaoge, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Lloyd-Pottiger,guo-shaoge]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 17, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 17, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-17 07:36:12.853386646 +0000 UTC m=+4407370.440496790: ☑️ agreed by Lloyd-Pottiger.
  • 2023-11-17 09:53:10.519854056 +0000 UTC m=+4415588.106964196: ☑️ agreed by guo-shaoge.

@JinheLin
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 17, 2023

@JinheLin: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@JinheLin
Copy link
Contributor Author

/run-integration-test

@JinheLin
Copy link
Contributor Author

/run-integration-test

@JinheLin JinheLin mentioned this pull request Nov 17, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot bot merged commit 1123f88 into pingcap:master Nov 17, 2023
6 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #8387.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 17, 2023
Closed
12 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Nov 17, 2023
@JinheLin @ti-chi-bot
This is an automated cherry-pick of pingcap#8369
423ca1c 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@JinheLin JinheLin mentioned this pull request Nov 20, 2023
Closed
12 tasks
JaySon-Huang added a commit to ti-chi-bot/tiflash that referenced this pull request Dec 29, 2023
@JaySon-Huang
Resolve conflict && pick Add total_user_read_bytes in ScanContext pin…
2303dad 
…gcap#7534, pingcap#8369
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@guo-shaoge guo-shaoge guo-shaoge approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tiflash storage RU may exceed the RU_PER_SEC
4 participants
@JinheLin @ti-chi-bot @guo-shaoge @Lloyd-Pottiger