-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Fix invalid memory access when shutting down #8409
*: Fix invalid memory access when shutting down #8409
Conversation
Signed-off-by: JaySon-Huang <tshent@qq.com>
/run-all-tests |
@@ -18,6 +18,7 @@ | |||
#include <common/types.h> | |||
|
|||
#include <atomic> | |||
#include <boost/noncopyable.hpp> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This header seems unnecessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is need by struct TemporarilyDisableMemoryTracker : private boost::noncopyable
in line 192
Co-authored-by: jinhelin <linjinhe33@gmail.com>
[LGTM Timeline notifier]Timeline:
|
/approve |
@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, JinheLin, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@JaySon-Huang: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests
If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-all-tests |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #8408
Problem Summary:
There is an invalid memory access. This is because the logging system is already closed
What is changed and how it works?
When
sub_root_of_query_storage_task_mem_trackers
and its children are destructoring, it means the process is shutting down and the logging system is stopped.Suppress the logging of these memory trackers.
Check List
Tests
throw Exception("Mock exception thrown");
tiflash/dbms/src/Server/Server.cpp
Lines 1707 to 1716 in 3d3a5f1
Side effects
Documentation
Release note