Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Storages: Update the length of Block queue and the number of read threads (#8702)" #8732

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

JinheLin
Copy link
Contributor

@JinheLin JinheLin commented Jan 25, 2024

close #8703

Reverts #8708 because performance regression found in clustered-index daily test

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 25, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 25, 2024
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 25, 2024
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 25, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 25, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-25 03:24:53.235045454 +0000 UTC m=+1017534.799343160: ☑️ agreed by JaySon-Huang.
  • 2024-01-25 03:25:26.695945773 +0000 UTC m=+1017568.260243479: ☑️ agreed by Lloyd-Pottiger.

@JinheLin
Copy link
Contributor Author

/run-all-tests

@JinheLin
Copy link
Contributor Author

/run-integration-test

@JinheLin
Copy link
Contributor Author

[2024-01-25T03:44:00.860Z] fullstack-test2/ddl/alter_exchange_partition.test: Running

[2024-01-25T03:45:22.546Z]   File: fullstack-test2/ddl/alter_exchange_partition.test

[2024-01-25T03:45:22.546Z]   Error line: 156

[2024-01-25T03:45:22.546Z]   Error: set @@tidb_enable_exchange_partition=1; alter table test.e exchange partition p0 with table test_new.e2

[2024-01-25T03:45:22.546Z]   Result:

[2024-01-25T03:45:22.546Z]     ERROR 1105 (HY000) at line 1: other error for mpp stream: From MPP<query:447258113766064129,task:1>: Poco::Exception. Code: 1000, e.code() = 2, e.displayText() = Exception: Receive TsoResponse failed, e.what() = Exception

[2024-01-25T03:45:22.546Z]   Expected:

[2024-01-25T03:45:22.546Z]     <nothing>

@ti-chi-bot ti-chi-bot bot merged commit bcc9e7f into release-6.5 Jan 25, 2024
5 checks passed
@JaySon-Huang JaySon-Huang deleted the revert-8708-cherry-pick-8702-to-release-6.5 branch January 25, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants