Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug: Add find key debug invoker #8853

Merged
merged 45 commits into from
Mar 26, 2024
Merged

Debug: Add find key debug invoker #8853

merged 45 commits into from
Mar 26, 2024

Conversation

CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Mar 20, 2024

What problem does this PR solve?

Issue Number: ref #8864

Problem Summary:

In order to investigate #8845

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 20, 2024
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 20, 2024
@CalvinNeo CalvinNeo changed the title init Debug: Add find key debug invoker Mar 20, 2024
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
Copy link
Member Author

CalvinNeo commented Mar 21, 2024

image
image

Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
1
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
f
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
z
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
dbms/src/Storages/KVStore/Region.h Outdated Show resolved Hide resolved
dbms/src/Debug/dbgKVStore/dbgFuncRegion.cpp Outdated Show resolved Hide resolved
dbms/src/Debug/MockTiDB.cpp Outdated Show resolved Hide resolved
dbms/src/Debug/MockTiDB.cpp Outdated Show resolved Hide resolved
dbms/src/Debug/dbgKVStore/dbgFuncInvestigator.cpp Outdated Show resolved Hide resolved
dbms/src/Debug/dbgKVStore/dbgFuncInvestigator.cpp Outdated Show resolved Hide resolved
dbms/src/Debug/dbgKVStore/dbgFuncInvestigator.cpp Outdated Show resolved Hide resolved
dbms/src/Debug/dbgKVStore/dbgFuncInvestigator.cpp Outdated Show resolved Hide resolved
Comment on lines 112 to 113
regSchemalessFunc("find_key_kvstore", dbgFuncFindKey);
regSchemafulFunc("find_key_dt", dbgFuncFindKeyDt);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some comments here to explain how to use this

f
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
z
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
z
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2024
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2024
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

contrib/tiflash-proxy-cmake/CMakeLists.txt Outdated Show resolved Hide resolved
contrib/tiflash-proxy-cmake/CMakeLists.txt Outdated Show resolved Hide resolved
contrib/tiflash-proxy-cmake/CMakeLists.txt Outdated Show resolved Hide resolved
contrib/tiflash-proxy-cmake/CMakeLists.txt Outdated Show resolved Hide resolved
contrib/tiflash-proxy-cmake/CMakeLists.txt Outdated Show resolved Hide resolved
contrib/tiflash-proxy-cmake/CMakeLists.txt Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 26, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-22 07:02:41.110732094 +0000 UTC m=+1619388.132978483: ☑️ agreed by Lloyd-Pottiger.
  • 2024-03-26 05:18:10.115538435 +0000 UTC m=+1958717.137784819: ☑️ agreed by JaySon-Huang.

@JaySon-Huang
Copy link
Contributor

/run-all-tests

Copy link
Contributor

ti-chi-bot bot commented Mar 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, JinheLin, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,JinheLin,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit ce8ae39 into pingcap:master Mar 26, 2024
6 checks passed
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels Apr 30, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #9006.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Apr 30, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Apr 30, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #9008.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #9012.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Apr 30, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants