-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix GeneratedColumnPlaceHolderTransformAction header (#8951) #8954
fix GeneratedColumnPlaceHolderTransformAction header (#8951) #8954
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guo-shaoge, yibin87 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/run-all-tests |
This is an automated cherry-pick of #8951
What problem does this PR solve?
Issue Number: close #8787
Problem Summary: Make sure header and block are both
const column
forGeneratedColumnPlaceHolderTransformAction
. Otherwisetiflash/dbms/src/DataStreams/MergeSortingBlockInputStream.cpp
Line 156 in 73f37f6
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note