Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage: Refine logging about reading snap, place index, index to wait #8973

Merged
merged 3 commits into from
Apr 22, 2024

Conversation

JaySon-Huang
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #8864

Problem Summary:

What is changed and how it works?

  • Add the index to wait in learner read logging
  • Add logging about place index result and snapshot rows/deletes
[2024/04/21 00:33:40.417 +08:00] [DEBUG] [Segment.cpp:2422] ["Begin segment getReadInfo <segment_id=1 epoch=1 range=[-9223372036854775808,9223372036854775807)>"] [thread_id=1]
[2024/04/21 00:33:40.418 +08:00] [DEBUG] [StableValueSpace.cpp:487] ["start_ts: 18446744073709551615, enable_handle_clean_read: false, is_fast_mode: false, enable_del_clean_read: false"] [source="segment_id=1 epoch=1"] [thread_id=1]
[2024/04/21 00:33:40.418 +08:00] [DEBUG] [DMFilePackFilter.cpp:118] ["RSFilter exclude rate: 0.00, after_pk: 2, after_read_packs: 2, after_filter: 2, handle_ranges: {[1,9223372036854775807)}, read_packs: 0, pack_count: 2"] [thread_id=1]
[2024/04/21 00:33:40.454 +08:00] [DEBUG] [Segment.cpp:2682] ["Finish segment ensurePlace, read_ranges={[-9223372036854775808,9223372036854775807)} placed_items=1 shared_delta_index=<placed_rows=0 placed_deletes=0 tree_entries=0 tree_inserts=0 tree_deletes=0> my_delta_index=<placed_rows=8192 placed_deletes=0 tree_entries=8192 tree_inserts=8192 tree_deletes=0> <segment_id=1 epoch=1 range=[-9223372036854775808,9223372036854775807)>"] [thread_id=1]
[2024/04/21 00:33:40.455 +08:00] [DEBUG] [Segment.cpp:2449] ["Finish segment getReadInfo, my_delta_index=<placed_rows=8192 placed_deletes=0 tree_entries=8192 tree_inserts=8192 tree_deletes=0> fully_indexed=true read_ranges={[-9223372036854775808,9223372036854775807)} snap={stable_rows=16384 persisted_rows=8192 persisted_dels=0 persisted_cfs=1 mem_rows=0 mem_dels=0 mem_cfs=0} <segment_id=1 epoch=1 range=[-9223372036854775808,9223372036854775807)>"] [thread_id=1]
[2024/04/21 00:33:40.455 +08:00] [DEBUG] [Segment.cpp:2461] ["Segment updated delta index, my_delta_index=<placed_rows=8192 placed_deletes=0 tree_entries=8192 tree_inserts=8192 tree_deletes=0> <segment_id=1 epoch=1 range=[-9223372036854775808,9223372036854775807)>"] [thread_id=1]

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 20, 2024
@JaySon-Huang
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Apr 21, 2024
@JaySon-Huang
Copy link
Contributor Author

/run-all-tests

Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

ti-chi-bot bot commented Apr 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, JinheLin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 22, 2024
Copy link
Contributor

ti-chi-bot bot commented Apr 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-21 00:55:05.252412262 +0000 UTC m=+731524.363458709: ☑️ agreed by JinheLin.
  • 2024-04-22 03:01:01.54639451 +0000 UTC m=+825480.657440959: ☑️ agreed by CalvinNeo.

@ti-chi-bot ti-chi-bot bot merged commit a3e48e4 into pingcap:master Apr 22, 2024
6 checks passed
@JaySon-Huang JaySon-Huang deleted the add_logging branch April 22, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants