-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Fix unstable schema test (#8972) #8975
Merged
ti-chi-bot
merged 4 commits into
pingcap:release-7.5
from
ti-chi-bot:cherry-pick-8972-to-release-7.5
May 7, 2024
Merged
tests: Fix unstable schema test (#8972) #8975
ti-chi-bot
merged 4 commits into
pingcap:release-7.5
from
ti-chi-bot:cherry-pick-8972-to-release-7.5
May 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
added
release-note-none
Denotes a PR that doesn't merit a release note.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
type/cherry-pick-for-release-7.5
This PR is cherry-picked to release-7.5 from a source PR.
labels
Apr 22, 2024
12 tasks
ti-chi-bot
added
the
cherry-pick-approved
Cherry pick PR approved by release team.
label
Apr 22, 2024
/run-all-tests |
JaySon-Huang
approved these changes
May 7, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
Indicates a PR needs 1 more LGTM.
approved
labels
May 7, 2024
Lloyd-Pottiger
approved these changes
May 7, 2024
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
Indicates a PR needs 1 more LGTM.
labels
May 7, 2024
[LGTM Timeline notifier]Timeline:
|
JaySon-Huang
pushed a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
cherry-pick-approved
Cherry pick PR approved by release team.
lgtm
release-note-none
Denotes a PR that doesn't merit a release note.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
type/cherry-pick-for-release-7.5
This PR is cherry-picked to release-7.5 from a source PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #8972
What problem does this PR solve?
Issue Number: close #8968, close #8911
Problem Summary:
#8955 introduced a check on the cache gc_safepoint is not updated, but the background task of DDL sync make the ut unstable
What is changed and how it works?
profiles.default.ddl_sync_interval_seconds == 0
TiDBSchemaManager.h
with comments on lockingschema_syncers_mutex
SchemaSyncTest
to use temporary instance instead of the instance inglobal_context
Check List
Tests
Side effects
Documentation
Release note