Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the redundant copy of join key column #9058

Merged
merged 7 commits into from
May 27, 2024
Merged

Remove the redundant copy of join key column #9058

merged 7 commits into from
May 27, 2024

Conversation

gengliqi
Copy link
Contributor

@gengliqi gengliqi commented May 16, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #9057

Problem Summary:

  1. fix Remove the redundant copy of join key column #9057
  2. this PR also removes the redundant column names in output_columns_names_set_for_other_condition_after_finalize.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@gengliqi
remove join copy key
abded1c 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 16, 2024
@gengliqi
Merge branch 'master' into remove-join-copy-key
f6af4bf
@gengliqi
rename
9c20ac7 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 16, 2024
@gengliqi
Copy link
Contributor Author

/run-all-tests

@gengliqi
fix interpreter tests
d52efe4 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 17, 2024
@gengliqi
Copy link
Contributor Author

/run-all-tests

@gengliqi
Copy link
Contributor Author

/run-all-tests

windtalker
windtalker reviewed May 23, 2024
View reviewed changes
dbms/src/TestUtils/FunctionTestUtils.cpp Outdated
expect_col.column->getName(),
actual_col.column->getName(),
fmt::format("Column {} name mismatch", i));
if (expect_col.column->getName() != actual_col.column->getName())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why change this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For debug, forget to change it back.

windtalker
windtalker approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels May 27, 2024
yibin87
yibin87 approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 27, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-27 02:35:57.156197342 +0000 UTC m=+2657510.913332915: ☑️ agreed by windtalker.
  • 2024-05-27 08:31:27.636305738 +0000 UTC m=+2678841.393441312: ☑️ agreed by yibin87.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 27, 2024

@gengliqi: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit a4fe694 into pingcap:master May 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yibin87 yibin87 yibin87 approved these changes

@windtalker windtalker windtalker approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the redundant copy of join key column
3 participants
@gengliqi @windtalker @yibin87