Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security: Do not let grpc reload ssh cert if not changed (#9068) #9070

Merged

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented May 22, 2024

This is an automated cherry-pick of #9068

What problem does this PR solve?

Issue Number: ref #8535

Problem Summary:

What is changed and how it works?

This pr does not fix #8535, but it will make sure if ssh cert is not changed, #8535 will not be triggered.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Reduced the probability of TiFlash crash due to ssh reload(#8535)

windtalker and others added 8 commits May 22, 2024 08:01
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
Co-authored-by: Rossi Sun <zanmato1984@gmail.com>
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels May 22, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 22, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels May 22, 2024
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 22, 2024
Copy link
Contributor

ti-chi-bot bot commented May 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-22 08:05:57.465416769 +0000 UTC m=+2245311.222552336: ☑️ agreed by zanmato1984.
  • 2024-05-22 08:09:19.822475281 +0000 UTC m=+2245513.579610854: ☑️ agreed by windtalker.

Copy link
Contributor

ti-chi-bot bot commented May 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gengliqi, windtalker, zanmato1984

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gengliqi,windtalker,zanmato1984]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels May 22, 2024
@windtalker
Copy link
Contributor

/run-all-tests

@windtalker
Copy link
Contributor

/run-unit-tests

1 similar comment
@windtalker
Copy link
Contributor

/run-unit-tests

@JaySon-Huang
Copy link
Contributor

Have we pick the related fix to release-7.5? @CalvinNeo

https://ci.pingcap.net/blue/organizations/jenkins/tiflash-ghpr-unit-tests/detail/tiflash-ghpr-unit-tests/13181/pipeline

[2024-05-22T09:28:58.998Z] �[0;33mNote: Google Test filter = ReadIndexTest.workers
[2024-05-22T09:28:58.998Z] �[m�[0;32m[==========] �[mRunning 1 test from 1 test case.
[2024-05-22T09:28:58.998Z] �[0;32m[----------] �[mGlobal test environment set-up.
[2024-05-22T09:28:58.998Z] �[0;32m[----------] �[m1 test from ReadIndexTest
[2024-05-22T09:28:58.998Z] �[0;32m[ RUN      ] �[mReadIndexTest.workers
[2024-05-22T09:28:58.998Z] [2024/05/22 17:28:49.144 +08:00] [WARN] [ProxyFFI.cpp:890] ["Set mock rust ptr gc function"] [source=MockSetRustGcHelper] [thread_id=1]
[2024-05-22T09:28:58.998Z] [2024/05/22 17:28:49.146 +08:00] [INFO] [ReadIndexWorker.cpp:997] ["Start read-index runner 2"] [source=ReadIndexWorkers] [thread_id=194]
[2024-05-22T09:28:58.998Z] [2024/05/22 17:28:49.148 +08:00] [INFO] [ReadIndexWorker.cpp:997] ["Start read-index runner 1"] [source=ReadIndexWorkers] [thread_id=195]
[2024-05-22T09:28:58.998Z] [2024/05/22 17:28:49.150 +08:00] [INFO] [ReadIndexWorker.cpp:997] ["Start read-index runner 0"] [source=ReadIndexWorkers] [thread_id=196]
[2024-05-22T09:28:58.998Z] /home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Storages/KVStore/tests/gtest_read_index_worker.cpp:376: Failure
[2024-05-22T09:28:58.998Z] Expected equality of these values:
[2024-05-22T09:28:58.998Z]   resps[2].first.read_index()
[2024-05-22T09:28:58.998Z]     Which is: 0
[2024-05-22T09:28:58.998Z]   669
[2024-05-22T09:28:58.998Z] libc++abi: terminating
[2024-05-22T09:28:58.998Z] Received signal Aborted

@ti-chi-bot ti-chi-bot bot merged commit ff8d390 into pingcap:release-7.5 May 22, 2024
5 checks passed
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants