-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
security: Do not let grpc reload ssh cert if not changed (#9068) #9070
security: Do not let grpc reload ssh cert if not changed (#9068) #9070
Conversation
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
Co-authored-by: Rossi Sun <zanmato1984@gmail.com>
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gengliqi, windtalker, zanmato1984 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/run-all-tests |
/run-unit-tests |
1 similar comment
/run-unit-tests |
Have we pick the related fix to release-7.5? @CalvinNeo
|
This is an automated cherry-pick of #9068
What problem does this PR solve?
Issue Number: ref #8535
Problem Summary:
What is changed and how it works?
This pr does not fix #8535, but it will make sure if ssh cert is not changed, #8535 will not be triggered.
Check List
Tests
Side effects
Documentation
Release note