Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storages: Refine build filters in StorageDeltaMerge #9104

Merged
merged 7 commits into from
Jun 13, 2024

Conversation

JinheLin
Copy link
Contributor

@JinheLin JinheLin commented May 30, 2024

What problem does this PR solve?

Issue Number: ref #9103

Problem Summary: Preparations for #9103.

What is changed and how it works?

Move some builder functions of filters to be a static member function of each class.
  • Move StorageDeltaMerge::buildRSOperator to RSOperator::build.
  • Move StorageDeltaMerge::buildPushDownFilter to PushDownFilter::build.
  • Move StorageDeltaMerge::parsePushDownFilter to PushDownFilter::build.
  • Make StorageDeltaMerge::parseRuntimeFilterList to a local function.
  • Make StorageDeltaMerge::parseMvccQueryInfo to a local function.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 30, 2024
@JinheLin
Copy link
Contributor Author

/run-all-tests

@JinheLin JinheLin requested review from Lloyd-Pottiger and JaySon-Huang and removed request for Lloyd-Pottiger May 30, 2024 08:22
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 31, 2024
@JinheLin
Copy link
Contributor Author

@JaySon-Huang PTAL.

Copy link
Contributor

ti-chi-bot bot commented Jun 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 13, 2024
Copy link
Contributor

ti-chi-bot bot commented Jun 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-31 05:03:08.051509551 +0000 UTC m=+3011941.808645118: ☑️ agreed by Lloyd-Pottiger.
  • 2024-06-13 09:54:15.020115731 +0000 UTC m=+631209.073427654: ☑️ agreed by JaySon-Huang.

Copy link
Contributor

ti-chi-bot bot commented Jun 13, 2024

@JinheLin: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@JinheLin
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot bot merged commit d399917 into pingcap:master Jun 13, 2024
5 checks passed
@JinheLin JinheLin deleted the refine_build_filter branch June 17, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants