Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SQL mode of ERROR_FOR_DIVISION_BY_ZERO #9107

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gengliqi
Copy link
Contributor

@gengliqi gengliqi commented May 31, 2024

What problem does this PR solve?

Issue Number: ref #9106

Problem Summary:

What is changed and how it works?

  1. make div and mod function support ERROR_FOR_DIVISION_BY_ZERO
  2. report warning if in read-only sql or non-strict sql mode

TODO: Error message and error code are still different from TiDB and TiKV.
img_v3_02bd_3431d323-27a7-4a09-83a8-4fb2343a04ag

Support SQL mode of `ERROR_FOR_DIVISION_BY_ZERO`

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Signed-off-by: gengliqi <gengliqiii@gmail.com>
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label May 31, 2024
Copy link
Contributor

ti-chi-bot bot commented May 31, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from gengliqi, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 31, 2024
@gengliqi gengliqi changed the title Support SQL mode of ERROR_FOR_DIVISION_BY_ZERO Support SQL mode of ERROR_FOR_DIVISION_BY_ZERO May 31, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 5, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant