Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storages: Fix read ranges of FastScan #9119

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Storages: Fix read ranges of FastScan #9119

merged 2 commits into from
Jun 5, 2024

Conversation

JinheLin
Copy link
Contributor

@JinheLin JinheLin commented Jun 5, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #9118

What is changed and how it works?

Shrinking the read ranges of FastScan.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the read ranges of FastScan to reduce duplicate data

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 5, 2024
CalvinNeo
CalvinNeo approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 5, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 5, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-05 06:52:06.00215821 +0000 UTC m=+3450479.759293793: ☑️ agreed by CalvinNeo.
  • 2024-06-05 07:14:20.660879789 +0000 UTC m=+3451814.418015364: ☑️ agreed by Lloyd-Pottiger.

@Lloyd-Pottiger
Copy link
Contributor

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2024
@JinheLin
Copy link
Contributor Author

JinheLin commented Jun 5, 2024

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2024
JaySon-Huang
JaySon-Huang approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, JaySon-Huang, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CalvinNeo,JaySon-Huang,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jun 5, 2024
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Jun 5, 2024
@ti-chi-bot ti-chi-bot bot merged commit 60a7e70 into pingcap:master Jun 5, 2024
4 of 5 checks passed
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 5, 2024
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #9121.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #9122.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 5, 2024
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #9123.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 5, 2024
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Jun 5, 2024
@ti-chi-bot @JinheLin
Storages: Fix read ranges of FastScan (#9119) (#9122)
72742dc 
close #9118

Shrinking the read ranges of FastScan.

Co-authored-by: jinhelin <linjinhe33@gmail.com>
ti-chi-bot bot pushed a commit that referenced this pull request Jun 6, 2024
@ti-chi-bot @JinheLin
Storages: Fix read ranges of FastScan (#9119) (#9123)
9daf448 
close #9118

Shrinking the read ranges of FastScan.

Co-authored-by: jinhelin <linjinhe33@gmail.com>
@JinheLin JinheLin deleted the fastscan_logical_split branch June 13, 2024 00:42
ti-chi-bot bot pushed a commit that referenced this pull request Jun 13, 2024
@ti-chi-bot @JinheLin
Storages: Fix read ranges of FastScan (#9119) (#9121)
d276752 
close #9118

Shrinking the read ranges of FastScan.

Co-authored-by: jinhelin <linjinhe33@gmail.com>
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Aug 2, 2024
@ti-chi-bot @JinheLin @JaySon-Huang
Storages: Fix read ranges of FastScan (pingcap#9119) (pingcap#9121)
c3eb918 
close pingcap#9118

Shrinking the read ranges of FastScan.

Co-authored-by: jinhelin <linjinhe33@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@CalvinNeo CalvinNeo CalvinNeo approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FastScan may return more data than expected
5 participants
@JinheLin @Lloyd-Pottiger @ti-chi-bot @JaySon-Huang @CalvinNeo